Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate Xcode build adapter against Wikipedia-iOS build #822

Open
1 task
lacasseio opened this issue Mar 29, 2023 · 3 comments
Open
1 task

Validate Xcode build adapter against Wikipedia-iOS build #822

lacasseio opened this issue Mar 29, 2023 · 3 comments

Comments

@lacasseio
Copy link
Member

As a user of the Xcode build adapter, I want to build a project with similar complexity as the Wikipedia-iOS build so that I can prove the build adapter works as advertised.

Acceptance Criteria

  • When invoking gradle Wikipedia -Dconfiguration=Debug -Dsdk=iphonesimulator, the build completes successfully.
@lacasseio
Copy link
Member Author

The Wikipedia build has the following particularities:

  • Presence of empty entries in PBXShellScriptBuildPhase#inputPaths; it's unclear if Xcode considers these empty path in its up-to-date checking.
  • Usage of SwiftPM, these seem to be transitive, meaning A -> B -> SwiftPM, project A would have access to SwiftPM products.
  • The build doesn't seem to be working locally; we only had some success via the Xcode build adapter

@lacasseio
Copy link
Member Author

According to our experiment, we should be able to propagate the SwiftPM manually from the transitive dependencies to its children.

@lacasseio
Copy link
Member Author

Let me go back on the last comment, it's actually a lack of the implicit dependency service which doesn't look for dependencies into PBXFrameworksBuildPhase's files. Forcing a dependency actually solve the issue. Much easier that propagating the SwiftPM dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

No branches or pull requests

1 participant