Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate Xcode build adapter against Signal-iOS build #821

Open
1 task
lacasseio opened this issue Mar 29, 2023 · 2 comments
Open
1 task

Validate Xcode build adapter against Signal-iOS build #821

lacasseio opened this issue Mar 29, 2023 · 2 comments

Comments

@lacasseio
Copy link
Member

As a user of the Xcode build adapter, I want to build a project with similar complexity as Signal-iOS build so that I can prove the build adapter works as advertised.

Acceptance Criteria

  • When invoking gradle Signal -Dconfiguration=Debug -Dsdk=iphonesimulator the build completes successfully.
@lacasseio
Copy link
Member Author

The Signal build has the following particularities:

  • You must clone the Git submodules
  • You must first invoke make dependencies
  • Cocopods installation seems to be failing; hence the build adapter must skip this step

There is also a particular behaviour that is triggered by Xcode when building the whole workspace, that is, the use of Clang vfsoverlay. It needs to be clarified why this particular behaviour is only triggered during a workspace build. The solution generates and passes the overlays to the target build. We are still validating the solution.

@lacasseio
Copy link
Member Author

The vfsoverlay should be something that is composed into the build adapter. This means we need a task that creates the overlay data, exports the data, another task that merges the overlay data into a usable file, and finally then passes it to the build settings. We need to merge the overlay because -ivfsoverlay (clang) can only be specified once as opposed to -vfsoverlay (swiftc).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

No branches or pull requests

1 participant