bench: additional work on node:bench - #65631
Open
jasnell wants to merge 14 commits into
Open
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
lib / src
jasnell
changed the title
jasnell
force-pushed
the
jasnell/node-bench-2
branch
2 times, most recently
from
August 29, 2026 15:42
4358154 to
f89fc50
Compare
jasnell
force-pushed
the
jasnell/node-bench-2
branch
from
August 30, 2026 20:21
6d78070 to
3163d0f
Compare
Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode
Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode
Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode
Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode
Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode
Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode
Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode
Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode
Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode
Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode
Support serializable context.diagnostic messages and optionally listen to diagnostic_channel messages Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode
jasnell
force-pushed
the
jasnell/node-bench-2
branch
from
September 3, 2026 15:39
3163d0f to
b50499a
Compare
jasnell
marked this pull request as ready for review
September 3, 2026 15:40
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #65631 +/- ##
==========================================
+ Coverage 90.06% 90.08% +0.02%
==========================================
Files 769 769
Lines 261316 262631 +1315
Branches 49631 50004 +373
==========================================
+ Hits 235354 236592 +1238
- Misses 17019 17066 +47
- Partials 8943 8973 +30
🚀 New features to boost your workflow:
|
Signed-off-by: James M Snell <jasnell@gmail.com>
Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up to the first PR here #65606 ...
The first 9 commits are from that PR. Unfortunately, we can't stack these properly so this PR looks way more inflated. Going to keep it Draft until the first lands.Refines the implementation of the new experimental
node:bench