node-api: make object property arrays const - #65621
Merged
nodejs-github-bot merged 1 commit intoSep 2, 2026
Merged
Conversation
Signed-off-by: umuoy1 <burningdian@gmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
Member
|
Thanks! FWIW, this API has already been documented as taking |
legendecas
approved these changes
Aug 28, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65621 +/- ##
==========================================
- Coverage 90.07% 90.05% -0.02%
==========================================
Files 751 751
Lines 254921 254921
Branches 48129 48127 -2
==========================================
- Hits 229627 229578 -49
- Misses 16479 16513 +34
- Partials 8815 8830 +15
🚀 New features to boost your workflow:
|
KevinEady
approved these changes
Aug 28, 2026
github-actions
Bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
|
Could someone take a look at why node-test-pull-request/76782 failed? Looks like only the AIX failed. |
Member
|
we'll restart CI when we know it's in a good state, those AIX failures are unrelated to this PR |
github-actions
Bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
Collaborator
vmoroz
approved these changes
Sep 1, 2026
trivikr
added
author ready
Collaborator
|
Landed in 3942bf7 |
github-project-automation
Bot
moved this from Need Triage
to Done
in Node-API Team Project
nodejs-github-bot
removed
the
commit-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
property_namesandproperty_valuesconst innode_api_create_object_with_properties()to match their read-only semantics.Refs: nodejs/node-addon-api#1735 (comment)