module: derive builtinModules from enabled builtin set

Signed-off-by: sjungwon03 <sjungwon03@gmail.com>

Author: sjungwon03

lib/internal/bootstrap/realm.js

@@ -334,7 +334,16 @@ class BuiltinModule {
 
   static getAllBuiltinModuleIds() {
     const allBuiltins = ArrayFrom(canBeRequiredByUsersWithoutSchemeList);
-    ArrayPrototypePushApply(allBuiltins, ArrayFrom(schemelessBlockList, (x) => `node:${x}`));
+    ArrayPrototypePushApply(
+      allBuiltins,
+      ArrayPrototypeMap(
+        ArrayPrototypeFilter(
+          ArrayFrom(schemelessBlockList),
+          (id) => canBeRequiredByUsersList.has(id),
+        ),
+        (id) => 'node:' + id,
+      ),
+    );
     return allBuiltins;
   }
 

lib/internal/modules/cjs/loader.js

@@ -492,20 +492,7 @@ Module.isBuiltin = BuiltinModule.isBuiltin;
 function initializeCJS() {
   // This need to be done at runtime in case --expose-internals is set.
 
-  let modules = Module.builtinModules = BuiltinModule.getAllBuiltinModuleIds();
-  if (!getOptionValue('--experimental-dtls')) {
-    modules = modules.filter((i) => i !== 'node:dtls');
-  }
-  if (!getOptionValue('--experimental-quic')) {
-    modules = modules.filter((i) => i !== 'node:quic');
-  }
-  if (!getOptionValue('--experimental-ffi')) {
-    modules = modules.filter((i) => i !== 'node:ffi');
-  }
-  if (!getOptionValue('--experimental-vfs')) {
-    modules = modules.filter((i) => i !== 'node:vfs');
-  }
-  Module.builtinModules = ObjectFreeze(modules);
+  Module.builtinModules = ObjectFreeze(BuiltinModule.getAllBuiltinModuleIds());
 
   initializeCjsConditions();
 

test/parallel/test-module-builtin-experimental.js

@@ -0,0 +1,35 @@
+'use strict';
+
+const common = require('../common');
+const { spawnSyncAndAssert } = require('../common/child_process');
+
+const experimentalBuiltins = [
+  ['dtls', '--experimental-dtls', common.hasDtls],
+  ['ffi', '--experimental-ffi', common.hasFFI],
+  ['quic', '--experimental-quic', common.hasQuic],
+  ['vfs', '--experimental-vfs', true],
+].filter(([, , available]) => available);
+
+for (const [id, flag] of experimentalBuiltins) {
+  const builtin = `node:${id}`;
+
+  spawnSyncAndAssert(process.execPath, [
+    '-e', `const m = require('node:module'); if (m.builtinModules.includes('${builtin}')) process.exit(1); try { require('${builtin}'); } catch (e) { if (e.code === 'ERR_UNKNOWN_BUILTIN_MODULE') process.exit(0); } process.exit(1);`,
+  ], { status: 0 });
+
+  spawnSyncAndAssert(process.execPath, [
+    flag,
+    '-e', `const m = require('node:module'); if (!m.builtinModules.includes('${builtin}')) process.exit(1); require('${builtin}');`,
+  ], { status: 0 });
+}
+
+const schemeOnlyBuiltins = ['node:test', 'node:sea'];
+if (common.hasSQLite) {
+  schemeOnlyBuiltins.push('node:sqlite');
+}
+
+for (const id of schemeOnlyBuiltins) {
+  spawnSyncAndAssert(process.execPath, [
+    '-e', `const m = require('node:module'); if (!m.builtinModules.includes('${id}')) process.exit(1); require('${id}');`,
+  ], { status: 0 });
+}