Skip to content
This repository has been archived by the owner on Jun 22, 2024. It is now read-only.

fake-names-generator : Names generated in console are different from ones saved in file #35

Open
senechalloic opened this issue Jan 24, 2021 · 1 comment

Comments

@senechalloic
Copy link

Thanks for this repository, I'm learning NodeJs and this helps me.

Issue

I think there is a small issue in project cli/commander/fake-names-generator.
When we choose to save the names, the display names are different than the one shown in the console.

RootCause

I think the issue come from logNames() and saveNames() that generate two times the names in cli\commander\fake-names-generator\bin\cli.js.

Possible solution

logNames() could return the generated names and pass it to saveNames().

@Thiruppathi
Copy link
Contributor

Thanks for bringing this up. It is a good point, I'll create a fix for this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants