Skip to content
This repository has been archived by the owner on Jun 22, 2024. It is now read-only.

"Conditional" actions running on all PRs #33

Open
bnb opened this issue Nov 9, 2020 · 0 comments
Open

"Conditional" actions running on all PRs #33

bnb opened this issue Nov 9, 2020 · 0 comments

Comments

@bnb
Copy link
Contributor

bnb commented Nov 9, 2020

Theoretically, both cli-yargs-countentriesindirectory.yaml and servers-express-api-with-express-and-handlebars.yaml should only be running on PRs against their respective projects because of this YAML (this specific example is from the GitHub Action for Express's YAML):

on:
  push:
    paths:
      - 'servers/express/api-with-express-and-handlebars/**'
  pull_request:
    paths:
      - 'servers/express/api-with-express-and-handlebars/**'

However, they're currently running on all PRs, which is incorrect.

According to the GitHub Actions Documentation, this should work (example from the docs):

on:
  push:
    paths:
    - '**.js'

I can't tell if I'm missing something or if this feature of GitHub Actions CI is broken, and I honestly can't tell what next steps are to figure that out. That said, with how this project is structured we either need to answer that and find a fix or change how we do CI within GitHub Actions.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant