Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test for execute bit on docker-entrypoint.sh #1583

Open
nschonni opened this issue Oct 20, 2021 · 0 comments · May be fixed by #1588
Open

Test for execute bit on docker-entrypoint.sh #1583

nschonni opened this issue Oct 20, 2021 · 0 comments · May be fixed by #1588

Comments

@nschonni
Copy link
Member

Environment

  • Platform:
  • Docker Version:
  • Node.js Version:
  • Image Tag:

Expected Behavior

Current Behavior

Old directory is usually copied to create a new major release line. This seems to lose the execute bit depending on the platform. This is caught by the upstream CI, but isn't caught here.

Possible Solution

Look at the setup upstream to see if there is something to use, or do a basic check for the execute bit in CI job that filters on only the entrypoint files

Steps to Reproduce

Additional Information
MasonM added a commit to MasonM/docker-node that referenced this issue Oct 23, 2021
@MasonM
feat: Add back BATS for testing images
f8853c4 
BATS was initially added to this repository in nodejs#802, but was then
removed in nodejs#1339. This adds it back, and hooks it up to Github Actions.

This also fixes nodejs#1583, which happened due to a bug in the "Build image"
step: the build context was set to the root project directory, which
meant the `COPY docker-entrypoint.sh /usr/local/bin/` instruction was
copying the base `docker-entrypoint.sh` file into the Docker image
instead of the one in the variant directory. Changing the context to the
variant directory solves that.
@MasonM MasonM linked a pull request Oct 23, 2021 that will close this issue
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add back BATS for testing images MasonM/docker-node
2 participants
@nschonni and others