Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation by adding jsDoc compatible method documentations #160

Open
jankapunkt opened this issue Sep 16, 2022 · 7 comments
Open
Labels
documentation 📑 Improvements or additions to documentation hacktoberfest

Comments

@jankapunkt
Copy link
Member

I found many functions lack of proper parameter descriptions, for example in server.js. Especially options are often completely undocumented.

@jankapunkt jankapunkt added the documentation 📑 Improvements or additions to documentation label Sep 16, 2022
@jankapunkt
Copy link
Member Author

Also the README should add a "migrate from 3.x" guide, even if there are no breaking issues

@jankapunkt
Copy link
Member Author

@HappyZombies @jorenvandeweyer I have fiddled around with RST but it's a real struggle 🙈

My proposal would be:

  • use a markdown template and update all guides to markdown-based
  • use jsDoc with jsDoc to markdown to auto-generate API docs
  • use GitHub actions + GitHub pages to auto-publish documentation instead of readthedocs

What do you think?

@jorenvandeweyer
Copy link
Member

I agree. I'd suggest using Vitepress! Simple to setup and markdown templates.

@jorenvandeweyer
Copy link
Member

If you want I can set it up.

@jankapunkt
Copy link
Member Author

@jorenvandeweyer sounds promising! We can try to work on this on a separate branch. Does it support jsDoc?

@jorenvandeweyer
Copy link
Member

@jankapunkt No it does not support jsDoc, do we need it?

@jankapunkt
Copy link
Member Author

I think we are good with the current docs for now but in the long run jsDoc is a good way for API docs as the functions are documented in place

@jankapunkt jankapunkt changed the title Improve documentation Improve documentation by adding jsDoc compatible method documentations Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📑 Improvements or additions to documentation hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants