Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Codebase]: Separation of Concerns with R Packages #2

Open
jimbrig opened this issue Dec 13, 2024 · 0 comments
Open

[Codebase]: Separation of Concerns with R Packages #2

jimbrig opened this issue Dec 13, 2024 · 0 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request question Further information is requested refactor Code refactoring and cleanup setup Setup & Initialization

Comments

@jimbrig
Copy link
Member

jimbrig commented Dec 13, 2024

Ideally we want to have better separation of concerns with minimal coupling between the various components of the GMH project (i.e. Entrata API Interactions, R Shiny Modules, Authentication Plumber API, Database Management, Data Pipeline Orchestration, etc.).

Could split the codebase into separate self-contained, independent yet cohesive R packages if deem necessary. My initial instincts would be to split out:

  • GMH "DataHub" (Verse) Package (gmhdatahub)
  • Leasing & Pre-Lease Logic
  • Market Survey Logic
  • Entrata API Wrapper Package (gmhentrata)
  • Authentication API and R Wrappers (gmhauth) - Note: should merge noClocksAuthR and noClocksAuthPlumber and remove unused code while refreshing underlying code
@jimbrig jimbrig added documentation Improvements or additions to documentation enhancement New feature or request question Further information is requested refactor Code refactoring and cleanup setup Setup & Initialization labels Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request question Further information is requested refactor Code refactoring and cleanup setup Setup & Initialization
Projects
None yet
Development

No branches or pull requests

1 participant