Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package Module Sharp should be a dep and not a dev-dep #4

Open
gbourne1 opened this issue Apr 26, 2021 · 1 comment
Open

Package Module Sharp should be a dep and not a dev-dep #4

gbourne1 opened this issue Apr 26, 2021 · 1 comment

Comments

@gbourne1
Copy link

The image.js file uses Sharp, so there is a runtime error because Sharp is only a dev dependency.

Suggest moving to dependency.

Error: Cannot find module 'sharp'
Require stack

@aeh
Copy link
Contributor

aeh commented Apr 26, 2021

Sharp is actually a peer dependency and kind of needs to be. Having different versions of Sharp in the same top level node app with different backing libvips binaries can cause issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants