Replies: 2 comments 12 replies
-
|
Thank you for your comment and feedback. I am slowly coming back to this package (I have had to take care of some other commitments and deadlines in my other parts of life). Your comment has come at the right time. I am prototyping some changes. Your comment is helpful to me because it confirms my concern that deleting the link might not be the best approach. There are a couple things I will need to unpack here. Let me take a few days (hopefully only a few days) and come back to this thread. What I have done so far is still "destructive" but I might be able to avoid this and come up with an alternative---I need to see how I can incorporate your ideas. Thank you. |
Beta Was this translation helpful? Give feedback.
-
|
@ThomasJorna Instead of using the link, I am using just As it is a keyword, export does not include it. See the GIF animation below. I just quickly changed the code so that the original transclude keyword will remain, and the content gets added just below it.
This is based on the |
Beta Was this translation helpful? Give feedback.
-
|
This is looks good enough now. Supporting source code transclusion is what I want for now. Otherwise I have to add more headlines for reference and more detailed headlines. Is it possible to transclude the |
Beta Was this translation helpful? Give feedback.
-
|
@stardiviner Thanks! Re the |
Beta Was this translation helpful? Give feedback.
-
|
Aha, indeed, sorry, my fault, I missed this in my head. |
Beta Was this translation helpful? Give feedback.
-
|
No worries :) |
Beta Was this translation helpful? Give feedback.
-
@ThomasJorna The issue is really not export. It's the structure of the resultant Org file. To illustrate, see the GIF below.
See the =#+transclude= keyword. Once transclusion is done, it should be part of the transcluded headline "Heading". But now it remains to be part of "First Heading" above. If you fold the first headline, the keyword disappears... This was my primary reason for "removing" the link (now keyword). There may be a way to delay the deletion until the transclusion actually happens. |
Beta Was this translation helpful? Give feedback.
-
|
Just to illustrate the issue of "separation" I am talking about... You could move the entire headline ("First Heading" in the example above) to totally different location together with the translude keyword. Now the keyword is separated from the transcluded text. When you save the buffer, where will transclusion place the text again (save buffer remove all transcluded text and add them back again to keep the file clean of trascluded text)? It will be the new place where the First Heading headline is, not the original place. I don't like this type of surprise. |
Beta Was this translation helpful? Give feedback.
-
|
Ah now I see what you mean! That is indeed a bit annoying, I have not tried this myself but I assume it works the way you expect it to in the current implementation, i.e. the transclusion stays were you put it? I don't really see an easy way of getting around that at the moment yeah, although for me this wouldn't really be a problem as I think of the transcluded content in relation with the rest of the headings anyway, nor do I move around my headings that often. But if you do prefer to manage bigger files with transcluded content this might be a problem. Thanks for your efforts, any chance you could push your changes to another branch of this repo so I could have a look? I would like to get familiar with the structure of the package so I can help out in a more concrete manner, but if the codebase is changing considerably it might not be very productive to look at it now 😅 |
Beta Was this translation helpful? Give feedback.
-
|
Yes. Will push a working branch soon-ish then. Thank you! |
Beta Was this translation helpful? Give feedback.
-
|
@ThomasJorna See also PR #69 for a quick summary of major breaking changes in it. |
Beta Was this translation helpful? Give feedback.
-
|
Fantastic! I will have a look at it during this week. |
Beta Was this translation helpful? Give feedback.
-
Hi nobiot, really love the package, this is exactly how I would want org-roam to function and prevents me from rewriting a ton of notes in different places.
However, the "destructive" nature of org-transclusion has been bothering me as well, and while it hasn't erased my work yet, it has come somewhat close. The most egregious thing that has happened has only been the deletion and non-reinsertion of some links, which is mildly annoying as I sometimes forgot that it did that. The problem I run into the most though, is org-transclusion simply not inserting the links, which is probably my fault since I use a lot of janky minor modes.
So I wanted to run an idea by you to see if it's feasible/you haven't tried it yourself. AFAIK, you decided to use the destructive version (partially) because otherwise exports would not work, which I get. However I think that could be fixed:
org-transclude-export, which creates a new temporary buffer and either-- does the "destructive" transclusion there, or, more elegantly perhaps
-- changes the
#+transclusionto#+includewith some modifications of:hlevelto:minlevel(this might not work that well)#+tranclusion-headerwhenorg-transclusion-modeis active, maybe like John Kitchin's implementation, but instead of making it:keymapdependent activating it whenever the minor mode is active.I do need to give the disclaimer that I haven't looked deeply your code myself, so this might me nonsense. In any case, hope to hear from you, if you think this is worth trying I would love to help work on an implementation.
Beta Was this translation helpful? Give feedback.
All reactions