Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Physics] Adding Bonan Wind Profiles with Unified RSL Approach #62

Open
drnimbusrain opened this issue May 4, 2023 · 1 comment
Open
Assignees
Labels
enhancement New feature or request

Comments

@drnimbusrain
Copy link
Member

@zmoon @angehung5 Decided to make this a separate issue to add the Bonan wind profiles with Unified RSL approach (eventual RSL_OPT = 1) to canopy-app, so we can be more robust and fully compare in-canopy wind profiles to Massman/MOST approach (RSL_OPT=0) for Wei-Ting's paper as well.

The code for the 2018 paper can be found at https://github.com/gbonan/CLM-ml_v0

This isn't all of the code you need to run it; if interested I have a full setup at https://github.com/zmoon/CLM-ml-mb

Wind profile computation starts with the above-canopy part (Eq. 19 in the paper):
https://github.com/gbonan/CLM-ml_v0/blob/881a5c44b86f92c4ce65b3268b190297fbb0bd65/CanopyTurbulenceMod.F90#L432
This uses utility functions here: https://github.com/gbonan/CLM-ml_v0/blob/881a5c44b86f92c4ce65b3268b190297fbb0bd65/CanopyTurbulenceMod.F90#L921
Obukhov length needed but we could make it an input.

Followed by within-canopy (Eq. 21 in the paper): https://github.com/gbonan/CLM-ml_v0/blob/881a5c44b86f92c4ce65b3268b190297fbb0bd65/CanopyTurbulenceMod.F90#L478

@drnimbusrain drnimbusrain added the enhancement New feature or request label May 4, 2023
@drnimbusrain drnimbusrain changed the title Adding Bonan Wind Profiles with Unified RSL Approach [Winds/Dynamics] Adding Bonan Wind Profiles with Unified RSL Approach Sep 6, 2023
@drnimbusrain drnimbusrain changed the title [Winds/Dynamics] Adding Bonan Wind Profiles with Unified RSL Approach [Physics] Adding Bonan Wind Profiles with Unified RSL Approach Sep 6, 2023
@drnimbusrain
Copy link
Member Author

drnimbusrain commented Jan 29, 2025

@angehung5 See Full Noah-MP code with NCAR's additions for unified RSL approach based on https://agupubs.onlinelibrary.wiley.com/doi/10.1029/2021MS002665, we could pull out and finally put that option into canopy-app to test against simple MOST-Massman constant RSL approach to add this, and evaluate against Fluxnet.

https://github.com/RAbolafiaRosenzweig/NoahMP_CanopyTurbulence/blob/main/module_sf_noahmplsm_CanopyTurbulence_AbolafiaRosenzweig.f90

I think here and above we can add this approach in a way...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants