Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

listeners: remove mutexes after removing dynamic ListenerAdd call from topic module #36

Open
stapelberg opened this issue Apr 12, 2017 · 0 comments
Open

listeners: remove mutexes after removing dynamic ListenerAdd call from topic module #36

stapelberg opened this issue Apr 12, 2017 · 0 comments

Comments

@stapelberg
Copy link
Member

It seems like all ListenerAdd calls are done at program startup, except for the topic module’s ListenerAdd call, which is set up whenever the topic for a channel is requested.

We could refactor this code such that a topic listener is always present, which would allow us to remove all dynamic ListenerAdd calls and subsequently all locks.
stapelberg added a commit to stapelberg/frank that referenced this issue May 6, 2017
@stapelberg
Refactor topic changer (no more dynamic listeners)
4b778ca 
This drops the github.com/jmoiron/sqlx dependency.

The “settopic” admin command is removed since you can trigger the code
by manually changing the topic instead.

related to issue nnev#36
stapelberg added a commit to stapelberg/frank that referenced this issue May 6, 2017
@stapelberg
authenticate at NickServ using IRC passwords
77209f5 
related to issue nnev#36, as it gets rid of a dynamic listener
stapelberg added a commit to stapelberg/frank that referenced this issue May 6, 2017
@stapelberg
listeners: remove mutexes
4477b90 
fixes issue nnev#36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stapelberg