Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert config/daily.pickle to config/reminders.yaml / config/alerts.yaml #99

Open
nmlorg opened this issue Jun 27, 2024 · 0 comments
Open
Assignees
Labels
cleanup Code changes that improve maintainability without changing behavior

Comments

@nmlorg
Copy link
Owner

nmlorg commented Jun 27, 2024

I think I have #97 (comment) mostly ready to go, but it's another hairy change that I want to break apart and commit in pieces (though each commit will introduce new incompatible data changes).

  • Convert each record from (time, events, message) to {'time': time, 'events': events, 'message': message}.
  • Change records[botusername, groupid] to records[botusername][groupid].
  • Convert {'message': message} to {'message_id': message['message_id'], 'message_type': ...} (to prevent lists of dicts — entities, photo, etc. — from needing to be stored).
  • Store curmap instead of events.
  • Either:
  • Have _daily_messages set records = multibot.conf['reminders'] and get _handle_alerts to use records = multibot.conf['alerts'].
@nmlorg nmlorg added the cleanup Code changes that improve maintainability without changing behavior label Jun 27, 2024
@nmlorg nmlorg self-assigned this Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code changes that improve maintainability without changing behavior
Projects
None yet
Development

No branches or pull requests

1 participant