Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest version of J1939 Digital Annex may not be compatible with pretty_j1939 #32

Open
jd-salazar opened this issue May 4, 2022 · 0 comments

Comments

@jd-salazar
Copy link

jd-salazar commented May 4, 2022

I have a file named J1939DA JAN2022.xlsx at work. Is this is the same as the Digital Annex mentioned in the HOWTO?

EDIT: Confirmed it is the same Digital Annex and that the latest version breaks compatibility with pretty_j1939.py create_j1939db-json.py due to a library not being able to handle xlsx files:

C:\Users\JavierSalazar\Documents\komodo_CAN\CAN_Processing\pretty_j1939>py create_j1939db-json.py -f "J1939DA JAN2022.xlsx" -w J1939DA_202201.json
Traceback (most recent call last):
  File "C:\Users\JavierSalazar\Documents\komodo_CAN\CAN_Processing\pretty_j1939\create_j1939db-json.py", line 750, in <module>
    J1939daConverter(all_inputs).convert(args.write_json)
  File "C:\Users\JavierSalazar\Documents\komodo_CAN\CAN_Processing\pretty_j1939\create_j1939db-json.py", line 37, in __init__
    self.digital_annex_xls_list = list(map(lambda da: self.secure_open_workbook(filename=da, on_demand=True),
  File "C:\Users\JavierSalazar\Documents\komodo_CAN\CAN_Processing\pretty_j1939\create_j1939db-json.py", line 37, in <lambda>
    self.digital_annex_xls_list = list(map(lambda da: self.secure_open_workbook(filename=da, on_demand=True),
  File "C:\Users\JavierSalazar\Documents\komodo_CAN\CAN_Processing\pretty_j1939\create_j1939db-json.py", line 43, in secure_open_workbook
    return xlrd.open_workbook(**kwargs)
  File "C:\Users\JavierSalazar\AppData\Local\Programs\Python\Python310\lib\site-packages\xlrd\__init__.py", line 170, in open_workbook
    raise XLRDError(FILE_FORMAT_DESCRIPTIONS[file_format]+'; not supported')
xlrd.biffh.XLRDError: Excel xlsx file; not supported
@jd-salazar jd-salazar changed the title Not sure if my J1939 Standard is the "Digital Annex" Mentioned in HOWTO? Latest version of J1939 Digital Annex may not be compatible with pretty_j1939 May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant