Skip to content

Commit 2e63e9e

Browse files
committed
Update CRAN comments
1 parent 02ec3bf commit 2e63e9e

File tree

2 files changed

+13
-34
lines changed

2 files changed

+13
-34
lines changed

DESCRIPTION

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
Package: NlsyLinks
22
Type: Package
33
Title: Utilities and Kinship Information for Research with the NLSY
4-
Version: 2.0.4.9001
5-
Date: 2016-03-25
4+
Version: 2.0.5
5+
Date: 2016-04-17
66
Author: Will Beasley, Joe Rodgers, David Bard, Michael Hunter, S. Mason
77
Garrison, and Kelly Meredith
88
Maintainer: Will Beasley <[email protected]>

cran-comments.md

Lines changed: 11 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -1,45 +1,24 @@
11
## Description
2-
This submission updates & improves various small things. Many changes are to keep up with CRAN policy changes since April 2014. For instance, a shorter title, and using `requireNamespace()` instead of `require()`. Please tell me if there's something else I should do for CRAN.
2+
This submission corresponds to the new version of testthat. One of the tests catching a failing condition needed to change. -Will Beasley
33

4-
After my first submission last night, Kurt caught that the URL in the description field wasn't enclosed in <...>; that is now corrected.
4+
Test environments
5+
-----------------------------------------------
56

6-
> I get
7-
>
8-
```
9-
Found the following (possibly) invalid URLs:
10-
URL: http://www.bls.gov/nls/nlsy79ch.htm)
11-
From: man/Links79Pair.Rd
12-
Status: 404
13-
Message: Not Found
14-
```
15-
> Can you pls fix? (Remove the final paren from the URL).
16-
>
17-
> In plain text (such as the Description field) it is recommended to enclode URLs in <...>
18-
19-
For some reason, that wasn't caught by the five remote test machines. I'm open to any suggestions how to configure these builds so they mimic CRAN machines and prevent more of my mistakes slipping through to a human. The five that I ran last night before my first submission were:
20-
21-
* [win-builder R-devel](http://win-builder.r-project.org/68aDSl8xhbGq/00check.log)
22-
* [win-builder R-release](http://win-builder.r-project.org/WstV5xxuzI3F/00check.log)
23-
* [Travis-CI `--as-cran`](https://travis-ci.org/LiveOak/NlsyLinks/builds/75873235#L1736)
24-
* [AppVeyor `--as-cran`](https://ci.appveyor.com/project/wibeasley/nlsylinks/build/1.0.29#L218)
25-
* [Werker](https://app.wercker.com/#buildstep/55d13044b006c1f91e048052)
26-
27-
-Will Beasley
28-
29-
## Test environments
30-
* Local Win8, R 3.2.2 patched
31-
* [win-builder (version="R-devel")](http://win-builder.r-project.org/GMzN79RmpJJU)
7+
* Local Ubuntu 14.04 LTS
8+
* [win-builder (version="R-devel")](http://win-builder.r-project.org/68aDSl8xhbGq)
329
* [Travis CI, Ubuntu 12.04 LTS](https://travis-ci.org/LiveOak/NlsyLinks/)
3310
* [AppVeyor, Windows Server 2012](https://ci.appveyor.com/project/wibeasley/nlsylinks)
34-
* [Werker, Docker](https://app.wercker.com/#applications/5590d20a4fea05eb7a02e590)
11+
<!-- * [Werker, Docker](https://app.wercker.com/#applications/5590d20a4fea05eb7a02e590) -->
12+
13+
R CMD check results
14+
-----------------------------------------------
3515

36-
## R CMD check results
3716
* No ERRORs or WARNINGs on any builds.
38-
* One NOTEs on win-builder.
17+
* One notable NOTE:
3918
1. The package size has a few large data files; the data size is around 4Mb. I believe the size is justified because it drastically reduces the code needed for the package user to start incorporating their outcomes on to the larger familial framework we've build. (One of the package's cornerstones is how we've linked the 24,000 participants within the 5,160 extended families.)
4019
a. The (uncompressed) CSV is needed for an important example how to incorporate the CSVs downloaded from the NLSY database. I've used only the necessary columns.
4120
b. The compressed RDA files have important participant data the allows the package user to incoporate
42-
* No other unexplainable NOTEs on the other builds.
21+
* No other unexplainable NOTEs. The AppVeyor bulid complains about the vingette, but I think that's something specific to that test environment, and not to the package.
4322

4423
## Downstream dependencies
4524
No other packages depend/import this one.

0 commit comments

Comments
 (0)