Missing Tests?

[ramarnat]

I have made some improvements to the ingester, but it looks like the way the tests work is to download the test files from a mongodb database. Is it possible to add those test files into the repo or provide it in some other way?

[jonhilgart22]

@ramarnat want to compare notes on your updates?

[ansukla-salesforce]

The files we used for testing are not shared as it depended on the specific customer use cases. It is possible to recreate these tests with your files, however I can understand that keeping these in mongodb etc. would be a pain.

[ramarnat]

@jonhilgart22 I moved some of the atomic functions to rust. I didn't want to make a a lot of other changes without the tests because the code seems to deal with a lot of edge cases, and without the tests it's hard to know what the impact of a change might be.

@ansukla-salesforce I understand why they maybe hard to share. maybe the tests can be shared under an NDA or private repo and we can run them independently before contribution. Maybe there is a way to do something via gihubactions that can run the tests without exposing the test files publicly.

[jonhilgart22]

The files we used for testing are not shared as it depended on the specific customer use cases. It is possible to recreate these tests with your files, however I can understand that keeping these in mongodb etc. would be a pain.

It would be great to see some test files to ensure existing functionality works!