-
-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mkNeovimPlugin: refactor lua code generation logic #2623
Conversation
a52b607
to
003e099
Compare
# Write the lua configuration `luaConfig.content` to the config file | ||
(setLuaConfig cfg.luaConfig.content) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: why is it ok to remove the null check? (configLocation != null
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because it should never be null
.
null
is a forbidden value. Or at least, it is fine as long as hasLuaConfig
is false
.
I made #2624 to see how we could implement a |
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at cf7e026 |
003e099
to
cf7e026
Compare
This pull request, with head sha This pull request will be automatically closed by GitHub.As soon as GitHub detects that the sha It is possible for this pull request to remain open if this detection does not happen, this usually happens when a force-push is done on this branch |
Follow-up of #2619
This keeps the current behavior of not adding a
plugins.*.luaConfig
option if it doesn't make sense (forrustacenvim
for e.g.).What has been removed is the ability/expectation for
configLocation
to benull
.