Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facebook share button links to incorrect URL #190

Open
craigstanton opened this issue May 9, 2017 · 1 comment
Open

Facebook share button links to incorrect URL #190

craigstanton opened this issue May 9, 2017 · 1 comment
Assignees
Milestone

Comments

@craigstanton
Copy link
Member

The Facebook button on the Share panel currently links to "https://niwa.github.io%2f" despite the meta tag in index.html indicating "https://niwa.github.io/tsunami-db". This current link goes to a 404 page and therefore the preview that should appear in the Facebook post is an error message.

This may be fixed when we start using a custom subdomain but it would be good if it could work when in a subwoofer such as /tsunami-db too.

@tmfrnz
Copy link
Collaborator

tmfrnz commented May 9, 2017

The share panel renderer currently assumes the website hosted on root
https://github.com/niwa/tsunami-db/blob/master/app/components/app/AppView.js#L712

Fix would require adding
+ window.location.pathname + '/'
here

@tmfrnz tmfrnz added the ready label May 9, 2017
tmfrnz added a commit that referenced this issue May 10, 2017
to allow sharing app when in subfolder, #190
@tmfrnz tmfrnz added story:review and removed ready labels May 10, 2017
@tmfrnz tmfrnz modified the milestone: Final release May 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants