Skip to content

Commit 370f399

Browse files
authored
Merge pull request #2477 from effigies/maint/dev_install
MAINT: Add dev install option, update CONTRIBUTING
2 parents bf6326a + c1fd509 commit 370f399

File tree

2 files changed

+12
-3
lines changed

2 files changed

+12
-3
lines changed

CONTRIBUTING.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,9 @@ Make sure to [keep your fork up to date][link_updateupstreamwiki] with the maste
5757
If you're adding a new tool from an existing neuroimaging toolkit (e.g., 3dDeconvolve from AFNI), check out the [guide for adding new interfaces to Nipype][link_new_interfaces].
5858

5959
To confirm that your changes worked as intended, [clone your fork][link_cloning] to create a local directory.
60-
In this local directory, run `python setup.py develop`.
61-
This will add your version of nipype to your local python environment.
60+
In this local directory, run `pip install -e .[dev]`.
61+
This will add your version of nipype to your local python environment and
62+
install dependencies needed for development.
6263

6364
Then, in this local nipype directory, run `make check-before-commit`. If you get no errors, you're ready to submit your changes!
6465

nipype/info.py

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,15 @@ def get_nipype_gitversion():
168168
# 'mesh': ['mayavi'] # Enable when it works
169169
}
170170

171+
172+
def _list_union(iterable):
173+
return list(set(sum(iterable, [])))
174+
175+
171176
# Enable a handle to install all extra dependencies at once
172-
EXTRA_REQUIRES['all'] = [val for _, val in list(EXTRA_REQUIRES.items())]
177+
EXTRA_REQUIRES['all'] = _list_union(EXTRA_REQUIRES.values())
178+
# dev = doc + tests + specs
179+
EXTRA_REQUIRES['dev'] = _list_union(val for key, val in EXTRA_REQUIRES.items()
180+
if key in ('doc', 'tests', 'specs'))
173181

174182
STATUS = 'stable'

0 commit comments

Comments
 (0)