fix: dominanceRatio cannot be null

nimiq · Nov 19, 2024 · e8365b2 · e8365b2
1 parent 22ec0c8
commit e8365b2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/nimiq-validators-trustscore/src/score.ts b/packages/nimiq-validators-trustscore/src/score.ts
@@ -2,7 +2,7 @@ import type { ScoreParams, ScoreValues } from './types'
 
 export function getDominance({ threshold = 0.15, steepness = 7.5, dominanceRatio }: ScoreParams['dominance']) {
   if (!threshold || !steepness || !dominanceRatio)
-    throw new Error('Balance, threshold, steepness, or total balance is not set')
+    throw new Error(`Dominance Ratio, threshold or steepness is not set. ${JSON.stringify({ threshold, steepness, dominanceRatio })}`)
   if (dominanceRatio < 0 || dominanceRatio > 1)
     throw new Error(`Invalid dominance ratio: ${dominanceRatio}`)
   const s = Math.max(0, 1 - (dominanceRatio / threshold) ** steepness)

diff --git a/server/utils/validators.ts b/server/utils/validators.ts
@@ -197,10 +197,10 @@ export async function fetchValidators(params: FetchValidatorsOptions): Result<Fe
       if (dominance)
         // @ts-expect-error The wallet expects a score object, but until these values are stable, we will use null
         v.score.dominance = dominance
-      else if (v.dominanceRatioViaBalance && v.dominanceRatioViaBalance !== -1)
+      else if (v.dominanceRatioViaBalance && v.dominanceRatioViaBalance && v.dominanceRatioViaBalance !== -1)
       // @ts-expect-error The wallet expects a score object, but until these values are stable, we will use null
         v.score = { ...nullScore, dominance: getDominance({ dominanceRatio: v.dominanceRatioViaBalance }) }
-      else if (v.dominanceRatioViaBalance && v.dominanceRatioViaSlots !== -1)
+      else if (v.dominanceRatioViaBalance && v.dominanceRatioViaSlots && v.dominanceRatioViaSlots !== -1)
       // @ts-expect-error The wallet expects a score object, but until these values are stable, we will use null
         v.score = { ...nullScore, dominance: getDominance({ dominanceRatio: v.dominanceRatioViaSlots }) }
     })