Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor template helpers #321

Open
rosle opened this issue Mar 15, 2022 · 4 comments
Open

Refactor template helpers #321

rosle opened this issue Mar 15, 2022 · 4 comments
Labels
type : improvement

Comments

@rosle
Copy link
Contributor

rosle commented Mar 15, 2022

Why

Extract any helpers to separate modules or classes rather than putting them all in a template file.

Who Benefits?

Developers who work on the template
@rosle
Copy link
Contributor Author

rosle commented Mar 15, 2022

I started working a bit on https://github.com/nimblehq/rails-templates/pull/318/files

@rosle
Copy link
Contributor Author

rosle commented Mar 15, 2022

Please take this into account #317 (comment)

@rosle rosle mentioned this issue Mar 15, 2022
Merged
@rosle
Copy link
Contributor Author

rosle commented Mar 17, 2022

Please take care of These Rubocop todos for Style/ClassAndModuleChildren - https://github.com/nimblehq/rails-templates/pull/320/files#r828745952

@rosle rosle mentioned this issue Mar 17, 2022
Merged
@rosle rosle added this to the 6.0.0 milestone Mar 17, 2022
@malparty malparty removed this from the 5.3.0 milestone Feb 2, 2023
@malparty
Copy link
Member

@rosle I think @sanG-github will soon work on the prompt flow which should also refactor some of the helpers, should you two have a small call about sharing what was intended in this issue?

Then could you let me know if this issue should be closed or reviewed? 👀

Many thanks 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type : improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rosle @malparty