3.0.0.22

Small fixes
nilsteampassnet · Feb 11, 2023 · 6d6cfcb · 6d6cfcb
1 parent d5bf889
commit 6d6cfcb
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 8 deletions.
diff --git a/api/Controller/Api/ItemController.php b/api/Controller/Api/ItemController.php
@@ -113,6 +113,9 @@ public function getAction(array $userData): void
     {
         $superGlobal = new protect\SuperGlobal\SuperGlobal();
         $strErrorDesc = '';
+        $sqlExtra = '';
+        $responseData = '';
+        $strErrorHeader = '';
         $requestMethod = $superGlobal->get('REQUEST_METHOD', 'SERVER');
 
         // get parameters

diff --git a/install/tp.functions.php b/install/tp.functions.php
@@ -243,11 +243,11 @@ function addNewSetting($table, $type, $label, $value): void
 
     // check if setting already exists
     $data = mysqli_fetch_row(mysqli_query($db_link, "SELECT COUNT(*) FROM ".$table." WHERE type = '".$type."' AND intitule = '".$label."'"));
-    if ($data[0] == 0) {
+    if ((int) $data[0] === 0) {
         // add setting
         mysqli_query(
             $db_link,
-            "INSERT INTO ".$pre."misc
+            "INSERT INTO ".$table."
             (`type`, `intitule`, `valeur`)
             VALUES ('".$type."', '".$label."', '".$value."')"
         );
@@ -268,13 +268,12 @@ function removeSetting($table, $type, $label): void
 
     // check if setting already exists
     $data = mysqli_fetch_row(mysqli_query($db_link, "SELECT COUNT(*) FROM ".$table." WHERE type = '".$type."' AND intitule = '".$label."'"));
-    if ($data[0] == 0) {
+    if ((int) $data[0] === 1) {
         // delete setting
-        DB::delete(
-            prefixTable('misc'),
-            'type = %s AND intitule = %s',
-            $type,
-            $label
+        mysqli_query(
+            $db_link,
+            "DELETE FROM ".$table."
+            WHERE type = '".$type."' AND intitule = '".$label."'"
         );
     }
 }