Opinion on code structure

[lil5]

Found your project on the fediverse

https://mastodon.social/@golang_discussions/109294976193078757

Here's my take:

1. Move the contents of types.go in to dff.go
2. Remove the DuplicateFilesFinder interface and make Find a pure public function
3. Move the anonymous function of walk dir to a private function to keep complexity down.
4. State the project license in your readme.

YAGNI

[nilesh-akhade]

Reiterating your suggestion with reasons, which may be wrong. Please correct if needed.

1. Unless there are more than half-dozen domain model structs. Don't put them in a separate file.
2. If there's only one implementation of the interface. Don't add the interface, it does not add any value.
3. If an anonymous function consists of more than 6 lines. It should be named.
4. Isn't the LICENSE file enough? GitHub even detects it and shows the license details on the project homepage.

[nilesh-akhade]

@lil5: Updated the code, as suggested. a9f2220

[lil5]

You seem to be more interested in engineering structure than minimizing complexity.

YAGNI: You Ain't Gonna Need It

Forcing an arbitrary maximum size doesn't work if it all deals with the same action.

Seeing code as steps that must be completed helps writing those major steps as comments, then writing the code below each, and where necessary adding separation.

[nilesh-akhade]

Apologies, I am having a hard time understanding your comment.

Forcing an arbitrary maximum size

What is this about?

writing major steps as comments

My guess is it is about my todo about complicated duplicate-detection logic. Do you think it should be okay if we just explain the logic in code comments? No need to refactor.