Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests #1

Open
nikosanif opened this issue Dec 17, 2021 · 2 comments · Fixed by #2
Open

Unit tests #1

nikosanif opened this issue Dec 17, 2021 · 2 comments · Fixed by #2
Labels
help wanted Extra attention is needed

Comments

@nikosanif
Copy link
Owner

nikosanif commented Dec 17, 2021 •
edited
Loading

Description

Currently, the application does not have any tests. Thus, we should write unit tests.

Motivation

Testing your Angular application helps you check that your app is working as you expect.

Suggested Implementation

  • Migrate from Karma to Jest
  • Start adding unit tests

Alternate Implementations

N/A
@nikosanif nikosanif added the help wanted Extra attention is needed label Dec 17, 2021
@theoklitosBam7
Copy link
Contributor

Nice motivation @nikosanif! I would also suggest to use Spectator to simplify unit tests, as it helps us get rid of all the boilerplate grunt work. What do you think?

@nikosanif
Copy link
Owner Author

Sure! I have not used it at all in the past and it looks quite interesting. Besides, the libraries provided by ngneat are quite strong! @theoklitosBam7 keep in mind that PRs are more than welcome! 😄

theoklitosBam7 added a commit to theoklitosBam7/angular-authentication that referenced this issue Jan 11, 2022
@theoklitosBam7
chore: setup unit testing tools
a738326 
- Add and configure Jest for unit testing.
- Remove Karma and Jasmine
related packages.
- Add @angular-builders/jest that allows us running
`ng test` with Jest instead of Karma & Jasmine.
- Add @ngneat/spectator
to simplify unit tests.

Partially resolves nikosanif#1
theoklitosBam7 added a commit to theoklitosBam7/angular-authentication that referenced this issue Jan 11, 2022
@theoklitosBam7
chore: setup unit testing tools
472bc65 
- Add and configure Jest for unit testing.
- Remove Karma and Jasmine related packages.
- Add @angular-builders/jest that allows us running `ng test` with Jest instead of Karma & Jasmine.
- Add @ngneat/spectator to simplify unit tests.

Partially resolves nikosanif#1
@theoklitosBam7 theoklitosBam7 mentioned this issue Jan 11, 2022
Merged
nikosanif pushed a commit that referenced this issue Jan 13, 2022
@theoklitosBam7
build: setup unit testing tools (#2)
61695a9 
- Add and configure Jest for unit testing.
- Remove Karma and Jasmine related packages.
- Add @angular-builders/jest that allows us running `ng test` with Jest instead of Karma & Jasmine.
- Add @ngneat/spectator to simplify unit tests.

Partially resolves #1
@nikosanif nikosanif reopened this Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: setup unit testing tools theoklitosBam7/angular-authentication
2 participants
@nikosanif @theoklitosBam7