Part of async custom command is not executed at all #2969

pawlakmaly · 2021-12-03T15:14:36Z

pawlakmaly
Dec 3, 2021

So I've got this custom command:

module.exports = class customClick {
  command(selector) {
    let [rawSelector, using] =
      typeof selector === "object"
        ? [selector.selector, selector.locateStrategy]
        : [selector, this.client.locateStrategy];
    let waitingMessage = `Waiting for element ${rawSelector} to be visible before click`;
    let scrollingMessage = `Scrolling to element ${rawSelector}`;

    return new Promise(async (resolve) => {
      await this.api.waitForElementVisible(using, rawSelector, waitingMessage);  // <-- after this line no code is executed
      await this.api.debug(scrollingMessage);
      await this.api.scrollTo(selector);
      await this.api.waitForTransitionEnds(selector);
      await this.api.click(selector);
      resolve();
    });
  }
};

When I test this function, only the waitForElementVisible() is executed, the rest is not:

import { NightwatchBrowser} from 'nightwatch';

module.exports = {
    after(browser: NightwatchBrowser) {
        browser.end()
    },
    "Browser Context": async function (browser: NightwatchBrowser) {
        const selectorObject = {
            selector: '//*[@data-test-id="search-form-submit"]',
            locateStrategy: 'xpath'
        };
        const selector = '[data-test-id="search-form-submit"]';
        const nonExistingSelector = '.NoneExisting';

        await browser.url('https://www.ecosia.org/')
            .waitForElementVisible('body')
            .verify.titleContains('Ecosia')
        await browser.customClick(selectorObject);
        await browser.customClick(selector);
        await browser.customClick(nonExistingSelector);
    },
};

log:

[Custom Click Test] Test Suite
==============================
\ Connecting to localhost on port 9515...

i Connected to localhost on port 9515 (718ms).
  Using: chrome (96.0.4664.45) on Windows platform.

√ Running Browser Context:

√ Element <body> was visible after 21 milliseconds.
√ Testing if the page title contains 'Ecosia' (19ms)
√ Waiting for element //*[@data-test-id="search-form-submit"] to be visible before click
√ Waiting for element [data-test-id="search-form-submit"] to be visible before click

But then I move the resolve() to click() callback it work as expected, why ?

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Part of async custom command is not executed at all #2969

{{title}}

{{editor}}'s edit

{{editor}}'s edit

Replies: 0 comments

Select a reply

Part of async custom command is not executed at all #2969

pawlakmaly Dec 3, 2021

Replies: 0 comments

pawlakmaly
Dec 3, 2021