-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Insulin Peak Time: confusing / wrong help text, may affect oref algorithm #347
Comments
Insulin Peak Time popup came from iAPS. It's problematic because it seems to suggest Fiasp is rapid-acting instead of ultra-rapid and Novolog/Humalog/Apidra aren’t mentioned at all. (It's still wrong in the newest version despite crowdin suggestions.) Refer to the Trio docs: Insulin Curves I'm pretty sure 75 should be 65, and 55 minutes should be 50 in the Trio docs. @MikePlante1 had found the times in the iAPS code: Good catch, this has been long time discussed in iAPS, most of us probably forgot this text is still kicking around. |
Corrected with PR #348 |
hey 👋 - no triage is done for 30 days 🤐 ... anybody? triage is required! |
Describe the bug
*OpenAPS settings pull information of which insulin curve type to select from the set insulin type of the configured pump. In my case it is Dash with Fiasp.
While making some adjustments / finetuning on the OpenAPS settings I discovered this help text:
This made me selecting "rapid-acting" Insulin curve manually as it states:
"Oref assumes for ultra-rapid (Lyumjev) & rapid-acting (Fiasp) curves minimal (35 & 50 min) and maximal (100 & 120 min) [...]"
Oref might interprete fiasp as ultra-rapid as well! So we need to check wich oref modell will be used in case of Fiasp. So maybe the wrong model might be selected.
Attach a Log
no log available
To Reproduce
Steps to reproduce the behavior:
Expected behavior
A clear and concise description of what you expected to happen.
Depending on the set insulin type in pump settings the correct Insulin curve (and therefore OpenASP curve type) should be set. After this check this help text may need an adjustment.
Screenshots
If applicable, add screenshots to help explain your problem.
Setup Information (please complete the following information):
Smartphone:
Pump:
CGM:
Trio Version:
Technical Details
If applicable, provide any technical details that might help in diagnosing the problem. This could include logs, error messages, or relevant configuration details.
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: