Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example Starfield .nif that gets corrupted by removing unused strings #254

Open
JMPZ11 opened this issue Sep 17, 2024 · 2 comments
Open

Comments

@JMPZ11
Copy link

JMPZ11 commented Sep 17, 2024

(This is still happening using the latest dev as of 30 minutes ago, as well as before the qt6 upgrade)

I have run all the other optimizations, several times - I've tried internal and external geometry -- I can't remove unused strings - when reloaded the file is completely corrupt

gatesm_door01_hatchplugfloor03.zip
gatesm_door01_hatchplugfloor03.afterremoveunused.zip

Sorry if this is the wrong place to submit issues!

fo76utils added a commit to fo76utils/nifskope that referenced this issue Sep 18, 2024
@fo76utils
Copy link

I have a fix to this issue now, it was apparently caused by the model being updated while the spell is running, and BSLightingShaderProperty having conditionals based on the name being non-empty. Those could be broken by a state where the string index is temporarily pointing to the wrong string. So, I changed the code to disable updates until processing is complete.

@JMPZ11
Copy link
Author

JMPZ11 commented Sep 29, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants