Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation error in GLI #247

Open
danaki opened this issue May 21, 2024 · 0 comments
Open

Compilation error in GLI #247

danaki opened this issue May 21, 2024 · 0 comments

Comments

@danaki
Copy link

danaki commented May 21, 2024

Hello,

submodule refers gli commit 8e43030b3e12bb58a4663d85adc5c752f89099c0
which seemingly has a typo in template definition

#	if GLM_ARCH == GLM_ARCH_X86
	template<length_t L, typename T, qualifier Q, bool Aligned>
	struct compute_sign<L, T, Q, false, Aligned>
	{
		GLM_FUNC_QUALIFIER static vec<L, T, Q> call(vec<L, T, Q> const& x)
		{
			T const Shift(static_cast<T>(sizeof(T) * 8 - 1));
			vec<L, T, Q> const y(vec<L, typename make_unsigned<T>::type, P>(-x) >> typename make_unsigned<T>::type(Shift));

			return (x >> Shift) | y;
		}
	};
#	endif

I'm getting

C:\work\nifskope\lib\gli\external\glm\detail\func_common.inl:198: error: 'P' was not declared in this scope
    vec<L, T, Q> const y(vec<L, typename make_unsigned<T>::type, P>(-x) >> typename make_unsigned<T>::type(Shift));
                                                                 ^

In later commits it is suposedly fixed. Am I doing it wrong?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant