Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hkPackedNiTriStripsData complement #10

Open
neomonkeus opened this issue Nov 27, 2014 · 0 comments
Open

hkPackedNiTriStripsData complement #10

neomonkeus opened this issue Nov 27, 2014 · 0 comments

Comments

@neomonkeus
Copy link
Member

Verify patch was added and if iterator is needed.

Provides access to the MOPP-info and corrects a few API texts.

https://www.dropbox.com/s/xpniuvaynwlwau2/hkPackedNiTriStripsData.h.diff?dl=0
https://www.dropbox.com/s/a90451eozrkelj0/hkPackedNiTriStripsData.cpp.diff?dl=0

How about this?
amorilia/niflib@50a17d6

The problem was that I needed access to , which you removed (the *Full() variant). That acess should be provided as well.

All parts of the hkTriangles are accessible - instead, I take it that you mean that the access isn't convenient for iteration, right? If you write the patch it will be even faster. :-)
Again, make sure setter and getter are symmetric, as in the remainder of the lib (it wasn't the case in your original patch).
Regarding the name, GetHkTriangles SetHkTriangles seems clearer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant