Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some stuff. #34

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix some stuff. #34

wants to merge 4 commits into from

Conversation

petroid
Copy link

@petroid petroid commented Sep 17, 2022

The format of color in config file has changed (again) since merge #13 which now breaks things therefore is no longer needed.
The colors property was populated in core but never used, so I get rid of initialization which fixed #32. Seems to have no side-effects.
Supposedly fixed #33.
Also made some cosmetic fixes here and there.

This reverts commit c73e38e.
made it possible to use plugin in environments with no gtk
1. bumped version
2. fixed pieces tab label alignment
@petroid
Copy link
Author

petroid commented Sep 17, 2022

Tested on Deluge 2.1.1 win_64 gtkui/webui and Deluge 2.1.1 DSM package webui

moved updateConfig() out of PiecesTab constructor due to race condition(?) happening after deluge daemon runs for a while
@petroid
Copy link
Author

petroid commented Sep 19, 2022

Commit a9dfb9e supposedly fixes #33.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot read properties of undefined (reading 'get_config') optional gtk dependency?
1 participant