Bug: Potential Integer Overflow in debug tools Clay__IntToString function

[Rechenmaschine]

The function Clay__IntToString(int integer) could overflow for INT_MIN due to signed integer negation (integer = -integer), possibly resulting in undefined behavior.

clay/clay.h

Lines 2281 to 2283 in a48d406

	if (integer < 0) {
	integer = -integer;
	}

[nicbarker]

Hello 🙂
his seems possible but I'm not sure that the implications are so severe - this is an internal function used for the debug tools, so it appears to me that the worst case is that the debug tools display the wrong value in the interface?

[Rechenmaschine]

I did not check in detail where this function is used, but in the current context you're right, it seems just fine. That said, I wanted to point out at a potential problem that may arise from incorrect usage later 🙂.

Arithmetic overflow for signed integers is undefined behavior in the C standard. Depending on the compiler and platform, this could lead to more severe consequences than just displaying the wrong value in the interface, so it might be worth fixing to avoid relying on implementation-specific behavior.