Skip to content
This repository has been archived by the owner on Nov 7, 2024. It is now read-only.

Latest commit

 

History

History
362 lines (232 loc) · 19 KB

CONTRIBUTING.md

File metadata and controls

362 lines (232 loc) · 19 KB

External Communitiy Contribution Guidelines for selected Project - Part one

🤝 Contributor Covenant Code of Conduct

This Contributor Covenant sets out the rules for how everyone in our community should behave. We promise to make the community a welcoming and respectful place for everyone, no matter who they are. Good behavior includes being understanding, respecting different opinions, and taking feedback well. Bad behavior includes things like bullying, using inappropriate language, or sharing someone's private information without their permission. Community leaders will make sure these rules are followed and might give warnings or ban people who don't follow them. These rules apply everywhere in the community, and they're based on similar rules used by other groups. You can find more details and translations if needed.

🤝 Contribution guidelines

Contributing to Storybook is welcomed and encouraged, with various avenues available for participation. Whether through proposing new features via the RFC process, submitting code for bug fixes and enhancements, integrating Storybook with new frameworks, improving documentation, providing examples, or developing addons, there are numerous ways to get involved. If you're unsure where to start, consider exploring existing issues and pull requests, joining community discussions, seeking guidance from project maintainers, and familiarizing with the project's guidelines is recommended.

🤝 Step by Step Procedure to contribute

  1. Node Version Management - Ensure you have a compatible Node version installed. Storybook specifies the Node version in the .nvmrc file. It's recommended to use fnm as the Node version manager and configure it with specific parameters using the fnm env command.

  2. Running the Local Development Environment:

    • If using Windows, it's recommended to use Windows Subsystem for Linux (WSL).
    • Run yarn start in the root directory to start a basic test Storybook "sandbox."
    • If encounter any errors, try rerunning yarn start a second time.
  3. Handling Issues - If there is any specific issues, follow the provided instructions for resolving them, such as running specific commands to identify and potentially remove unintentional local changes.

  4. Forked Repositories - If the repository is forked, disable GitHub Actions for repo to prevent potential failures due to lack of proper authorization.

  5. Running against Different Sandbox Templates - One can choose a specific template to use for your sandbox to select the desired template and task.

  6. Making Code Changes - If there is need to make code changes to Storybook packages while running a sandbox, follow the provided steps.

  7. Contributing to Storybook - For further guidance on contributing, refer to the NEW contributing guide on the Storybook website.

References

🔗 Contributor Covenant Code of Conduct - https://github.com/storybookjs/storybook?tab=coc-ov-file#readme

🔗 Readme.md - https://github.com/storybookjs/storybook?tab=readme-ov-file#contributing

🔗 Contribution.md - https://github.com/storybookjs/storybook/blob/next/CONTRIBUTING.md

🔗 Contribution guidelines - https://storybook.js.org/docs/contribute



Community Code Contribution Information - Part one

Project - Storybook

📘 About Storybook

Storybook is like a workshop for frontend developers where they can build, test, and showcase individual pieces of a website or app (called UI components) without needing to put them together in the entire project. It helps developers work on these pieces faster and more easily, making sure they look and behave as intended before putting them into the final project. Storybook boasts an active and vibrant community of developers who contribute to its development, share knowledge, and provide support through platforms like GitHub Discussions, Discord, blogging, and social media channels. Storybook receives support from sponsors and backers who contribute financially to the project's development and maintenance. It also operates under the MIT license, allowing for widespread adoption and usage.

Supported Frameworks of Storybook which supports multiple frontend frameworks are React, Angular, Vue.js, Svelte, Ember, Preact, and others. It also extends support to mobile development frameworks like React Native and native mobile platforms like Android, iOS, and Flutter.

🤝 Contribution Details

Forked Repository link - Storybook

Issue Labels

  • angular
  • CLI
  • documentation
  • good first issue
  • help wanted

🔍 Detailed Explanation of Issue

The problem described in the issue is related to the lack of clear documentation regarding the usage of Compodoc within a Command Line Interface (CLI). When users encounter this prompt within the CLI, asking if they want to use Compodoc, they express a need for more detailed information on what Compodoc does and how it integrates with the project workflow as, this is an angular project.

The provided links offer additional context by directing to a Stack Overflow question discussing the utilization of Compodoc for Storybook documentation. This implies that the users seek clarity on how Compodoc can be utilized in conjunction with Storybook.

✅ Work Done

To contribute to an open-source project of community code part 1:

  • I Forked and cloned the project to my machine.
  • After that, I establish a new branch with name compodoc_info to work upon the issue.
  • Did research about compodoc documentation for angular projects which provided as references.
  • Then after, I create a file with name "compodoc_readme.md" and add everything relevant to the topic.
  • Also, I made a contribution file under name "compodoc_contribtuion.md" to describe my contribution for this work.
  • Then I commit and push all the content to GitHub.

✨ Code Review and Outcome

The documentation got reviewed by Baljit Singh, and he told me to add a section in my readme which describes some "Real-world examples" who uses compodoc documentation for the Angular projects which , I added now.

✨ Reflection on Success

Upon successful completion of this issue, I gained some useful knowledge regarding a completely new topic Although, this is a documentation issue but, this needs a lot of research as, this topic is completely new to me and requires time to work upon. Also, I learned the importance of clear documentation. This experience emphasized the significance of seeking clarification, and advocating for change to drive positive outcomes and enhance the user experience.

✨ Next Steps

As I gain knowledge on this topic, my curiosity drives me to seek further understanding through additional research. Furthermore, I aim to put it into practice to observe its practical outcomes firsthand.

✨ References

🔗 Vincent Ogloblinsky, "Compodoc: Documentation Tool for Angular 2+ Applications," ( 9 November, 2016), Medium

🔗 Compodoc README, (n.d.), GitHub

🔗 "How to generate documentation in Angular Compodoc," December 31, 2023, Cloudhadoop

🔗 Vincent Ogloblinsky, "Compodoc: The missing documentation tool for your Angular, Nest, Stencil application," (n.d.), Compodoc

🔗 "Set up Compodoc for Storybook on Nx," (n.d.) NX doc



Community Code Contribution Information - Part two

Project - Pattern Library

📘 About Pattern Library

The "DGL 104 Pattern Library," which includes implementing common software design patterns and describing architecture patterns in various programming languages. Contributions must adhere to open-source project standards, including pull request submissions and issue management for students to contribute and learn.


🤝 Contribution Details - Issue 1

Forked Repository link - Pattern library

✨ About selected Issue 1

For this issue, I need to integrate the Singleton pattern into our React Native app. This pattern ensures that only one instance of a specific class exists in the entire application, which is beneficial for managing shared resources efficiently. By implementing the Singleton pattern, we can guarantee consistency and prevent resource wastage in our app.

🤝 Contributors

  • Baljit Singh
  • Anjitha Karuthara Balakrishnan
  • Sandhya Basran

✅ Work Done

  • I choose this issue, by filtering with some labels and then, fork and clone it into my machine.
  • Next, I made a separate area for working on this specific problem called "react_native_development."
  • For this issue , I submit two pull request, one is my individual work and another is group work.
  • We meet and talked about the feedback had made about our first pull request and address that changes to create a new PR.
  • Then, I commit and push the work to Github.

The new Pull request is submitted from my forked repository

The provided is an outcome for the initial pull request under file name "Mysingleton.js" along with a descriptive file which was "contribution.md" to specify everything about react- native and singleton.

class MySingleton {
  static instance;

  constructor() {
    if (MySingleton.instance) {
      throw new Error("Singleton instance already exists. Use getInstance method.");
    }

    this.myProperty = "Initial Value";

    MySingleton.instance = this;
    Object.freeze(MySingleton.instance);
  }

  static getInstance() {
    if (!MySingleton.instance) {
      MySingleton.instance = new MySingleton();
    }
    return MySingleton.instance;
  }

  myMethod() {
    console.log('Singleton method has been called.');
  }

  anotherMethod() {
    console.log('Another method of the Singleton has been called.');
  }
}

// Usage in a React Native component
import React, { Component } from 'react';
import { View, Text, Button } from 'react-native';

export default class MyComponent extends Component {
  constructor(props) {
    super(props);

    // Get the singleton instance
    this.singletonInstance = MySingleton.getInstance();
  }

  handleButtonClick = () => {
    // Call methods of the singleton instance
    this.singletonInstance.myMethod();
    this.singletonInstance.anotherMethod();
  };

  render() {
    return (
      <View>
        <Text>React Native Singleton Example</Text>
        <Button title="Call Singleton Methods" onPress={this.handleButtonClick} />
      </View>
    );
  }
}


For new pull request, we decided to go with three different files named as "Singleton_pattern.js" which is for the react native code. Another one is a readme file under name "Singleton_readme.md" to describe all about react-native for singleton pattern implementation. Lastly, we create a contribution file to describe our contributions for the outcome of this issue with name "Singleton_contribution.md"

Here is the final outcome in support of this issue

// SingletonExample.js

import React, { Component } from 'react';
import { View, Text, Button } from 'react-native';

class MySingleton {
  constructor() {
    if (MySingleton.instance) {
      return MySingleton.instance;
    }
    MySingleton.instance = this;

    // Initialize properties
    this.myProperty = "Initial Value";
  }

  // Instance method example
  myMethod() {
    console.log('Singleton method has been called.');
  }

  // Another instance method example
  anotherMethod() {
    console.log('Another method of the Singleton has been called.');
  }

  // Static method to get instance
  static getInstance() {
    if (!MySingleton.instance) {
      MySingleton.instance = new MySingleton();
    }
    return MySingleton.instance;
  }
}

class SingletonExample extends Component {
  constructor(props) {
    super(props);

    // Get the Singleton instance
    this.singletonInstance = MySingleton.getInstance();
  }

  render() {
    return (
      <View>
        <Text>Singleton Example Component</Text>
        <Text>Property value: {this.singletonInstance.myProperty}</Text>
        <Button
          title="Call Singleton Method"
          onPress={() => this.singletonInstance.myMethod()}
        />
      </View>
    );
  }
}

export default SingletonExample;

✨ Code Review and Outcomes

Sumit Joshi did our code review for this issue. We met at college for the discussion on this issue. He suggest us to do some changes in the code. As, in my first pull request, I gave the react native code after the conse.log statement. He told me add it from the starting of the code to enhance its structure and clarity as well.

Also, I got bunch of reviews from my last pull request regarding some changes suggested for the contribution.md file which is to remove anything not directly related to React Native for the singleton pattern, like the benefits section. Also, advised to properly formatting references in the README file according to MLA or APA style, and using hyperlinks where needed. Additionally, there is recommendations including a relevant example in the README, properly formatted with triple backticks.

✨ Reflection on success

Through implementing the Singleton pattern, I have learned how to ensure only one instance of a class exists in the React Native application. This experience has also taught you about effective code organization, instance management, event handling, and the reflection on design pattern choices for future projects.

✨ Reference

🔗 Singleton Pattern - Design Patterns. (2019, February 21). https://www.youtube.com/watch?v=sJ-c3BA-Ypo

🔗 React Native Design Patterns tutorial. (2019, Aug 12). https://www.youtube.com/playlist?list=PLTgRMOcmRb3M2cPN_6iDDOYn8FONTkc3N

🔗 How to use Singleton in react native?.(2019, Mar 2). https://www.youtube.com/watch?v=rFy2hAq5xm4&t=140s

🔗 react-native-best-way-to-create-singleton-pattern.(n.d.). https://stackoverflow.com/questions/44023879

🔗 Using the Singleton Pattern in React. (2024 ,Mar 17). https://dev.to/antonzo/using-singleton-pattern-in-react-268n

🔗 React Fundamentals. (n.d.). https://reactnative.dev/docs/intro-react

🔗 Singleton Method Design Pattern in JavaScript. (n.d.). https://www.geeksforgeeks.org/singleton-design-pattern-introduction/

🔗 Mastering the Singleton Pattern. (2023, Jan 15). https://medium.com/@fakhrijalleli/mastering-the-singleton-pattern-e8f58395cae1



🤝 Contribution Details - Issue 2

Forked Repository link - Pattern library

✨ About selected Issue 2

For the issue "Write definition of Strategy pattern in README.md," I need to add a section to the README.md file of the "DGL 104 Pattern Library" project. This section should provide a clear and concise definition of the Strategy pattern, including its purpose, benefits, how it works, implementation guidelines, and example use cases. Ensure that the information is easy to understand and relevant for other developers using the library. Once added, commit the changes to the repository.

✅ Work Done

  • I choose this issue, forked and cloneed it into my machine.
  • Next, I made a separate branch for working on this specific problem called "template_pattern_docs."
  • I made two files to work on this issue with name template_readme.md to give my solved issue content and template_contribution.md file to describe my contribution.
  • For this issue , I submit two pull request, I submitted a pull request on which I got some changes requested to be done. Write definition of Template pattern in README.md #66 #93.
  • Changes Requested
    • Remove the issue link from readme file.
    • Change the structure in the components section.
  • I did the changes and commit and push the work to Github.

✨ Code Review and Outcomes

The work also got reviewed by Bhoomi and she do not have any suggestion on the work. She found it well written.

✨ Reviews to others Work

  1. jaskaransingh9990 - Add defination of Strategy pattern #84
  2. mrsaif888 - Contrast functional patterns vs. OOP design patterns in README.md #27 #92
  3. Bhoomi3637 - Add Java implementation for Observer pattern #35 #80
  4. AditiVatish - Add Java implementation for Observer pattern #35 #81


✨ References

🔗 Refactoring Guru. (n.d.). Template Method Design Pattern. https://refactoring.guru/design-patterns/template-method

🔗 GeeksforGeeks. (n.d.). Template Method Design Pattern. https://www.geeksforgeeks.orgtemplate-method-design-pattern/

🔗 Tutorialspoint. (n.d.). Template Method Design Pattern. https://www.tutorialspoint.com/design_pattern/template_pattern.html