-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lighthouse failing with axe-core Error: Cannot read properties of undefined (reading 'actualNode') #1650
Comments
# Pull Request ## 🤨 Rationale Attempt to see if upgrading dependencies stops the lighthouse internal error reported by #1650 In the process of updating disabled the validation (error -> warn) as it appears changes in lighthouse causes a lower score ## 👩💻 Implementation Upgraded the lighthouse version ## 🧪 Testing Relying on CI. ## ✅ Checklist - [x] I have updated the project documentation to reflect my changes or determined no changes are needed.
@kjohn1922 thanks for digging in and finding a workaround for what was breaking axe core in lighthouse. If you're feeling ambitious can try to reproduce and report it upstream to https://github.com/dequelabs/axe-core |
Found a way to reproduce the axe-core error in dev tools when running against lighthouse:
A bookmarklet version of the script:
|
# Pull Request ## 🤨 Rationale Disables the Card in the Angular and Blazor example apps as it breaks axe-core tooling used by lighthouse, see: #1650 ## 👩💻 Implementation Disabled the nimble-card in the Angular and Blazor apps Re-enabled the accessibility lighthouse error. The thought is that with this change the accessibility score will be reliably calculated and not cause intermittent blocking of merges, only blocks on merges that further regress the score. If it is not the case and lighthouse becomes unreliable calculating the score we can disable it again. Removed the exisiting comment for an issue to get us back to 0.9 score as there are multiple issues impacting our score now. ## 🧪 Testing Relying on lighthouse CI execution. ## ✅ Checklist - [x] I have updated the project documentation to reflect my changes or determined no changes are needed.
Assigning to myself to file an issue upstream to axe-core |
Created a minimal reproducing example that causes the lighthouse failure live page: https://axecore-lighthouse-failure.glitch.me/ Reported an issue to axe-core so hopefully they can handle shadow roots better: dequelabs/axe-core#4335 Reported an issue to lighthouse so hopefully they can be more robust to axe-core failures and still generate accessibility scores: GoogleChrome/lighthouse#15828 Marking the issue blocked. If either the lighthouse or axe-core issue is resolved we may be able to unblock this issue and re-enable the nimble-card in the angular app: nimble/angular-workspace/projects/example-client-app/src/app/customapp/customapp.component.html Lines 45 to 59 in fe357da
|
# Pull Request ## 🤨 Rationale The card was previously disabled after it started resulting in axe-core completely failing. After reporting to axe-core their comment in dequelabs/axe-core#4335 (comment) made me think we can workaround the axe-core issue by wrapping the slot in a span and targeting that instead for aria. While not necessary for runtime behavior or accessibility, the workaround adds minimal overhead and complexity. Does not need to be removed after the axe-core fix. Fixes #1650 ## 👩💻 Implementation Wraps the slot in a span and use that as the aria target. ## 🧪 Testing Can see the PR has a passing lighthouse score with the card re-enabled. ## ✅ Checklist - [x] I have updated the project documentation to reflect my changes or determined no changes are needed.
🧹 Tech Debt
Looks like lighthouse is failing intermittently on main, since: 090ed10
See: https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1699279168857-58396.report.html
And consistently with the changes proposed here: #1646
See: https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1699279168857-58396.report.html
With error message:
See:
Issue status: @kjohn1922 found a workaround in #1646, we should try and report it upstream to axe-core or lighthouse
The text was updated successfully, but these errors were encountered: