Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scaling outcome before estimation of Q #70

Open
Lauren-EylerDang opened this issue Aug 2, 2023 · 2 comments
Open

scaling outcome before estimation of Q #70

Lauren-EylerDang opened this issue Aug 2, 2023 · 2 comments

Comments

@Lauren-EylerDang
Copy link

Hi Nima, It appears that txshift is scaling the outcome prior to estimating Q. Is it possible to add an option so that Q can be estimated on its original scale? Thank you!
@Lauren-EylerDang
Copy link
Author

I created a pull request to estimate Q prior to scaling the outcome. Please consider if you think this is helpful for the package.

@nhejazi
Copy link
Owner

nhejazi commented Aug 21, 2023

Thanks for your question and interest in this, Lauren. I'll review PR #71 and try to get it merged soon. The contribution is appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nhejazi @Lauren-EylerDang