Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix: array with non-writable length #1371

Closed
wants to merge 1 commit into from

Conversation

bahador-r
Copy link

When I use the setTranslation method in my project, I get the following error:

ERROR Error: Uncaught (in promise): TypeError: can't define array index property past the end of an array with non-writable length
addLangs/<@http://localhost:4200/vendor.js:145411:20
addLangs@http://localhost:4200/vendor.js:145409:11

When I use the setTranslation method in my project, I get the following error: 

ERROR Error: Uncaught (in promise): TypeError: can't define array index property past the end of an array with non-writable length
addLangs/<@http://localhost:4200/vendor.js:145411:20
addLangs@http://localhost:4200/vendor.js:145409:11
Copy link

@soheilrghb soheilrghb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code does not logically change the project and prevents the error.

Copy link

@logicchemie logicchemie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

array with non-writable length

@CodeAndWeb
Copy link
Member

That change looks good for me.

However, how are you able to make this.langs (or this._langs) read-only from outside?

@CodeAndWeb
Copy link
Member

0818cec

@CodeAndWeb CodeAndWeb closed this Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants