Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Angular 11 (as peer dependency)? #1270

Open
splincode opened this issue Nov 28, 2020 · 9 comments
Open

Support Angular 11 (as peer dependency)? #1270

splincode opened this issue Nov 28, 2020 · 9 comments

Comments

@splincode
Copy link

No description provided.

@marcobuschini
Copy link

I want to migrate my codebase to Angular 11, too. Support for it would be lovely.

@lulzzz
Copy link

lulzzz commented Dec 10, 2020

Need this as well.

@ocombe
Copy link
Member

ocombe commented Dec 21, 2020

The current version of ngx translate requires angular >=10, which should include v11 according to semver

@Whisper40
Copy link

I have Angular 11 since the beggining, no problem with translation.

@yusufsarikaya023
Copy link

I used too in Angular 11 , no problem great work

@schlagi123
Copy link

If it works with angular 11, you can write this in the documentation/readme.md. WIth that this issue will be done.

@davidmarquis
Copy link

davidmarquis commented Jan 7, 2021

@schlagi123 great suggestion, go ahead and submit a pull request!

EDIT: It's already there, sorry! :) #1269

@schlagi123
Copy link

@davidmarquis #1269 updates also the angular version and try to create a new version of the @ngx-translate/core. Its a little bit to much.

@SchnWalter
Copy link

This issue can be closed, just update to v13.

On v12 there's an install warning because Angular v11 switched to tslib@2 and the published version at the time (v12) required a peer dependency of tslib@1. ng-packagr changed the output of libraries and tslib is no longer a peer dependency, see the CHANGELOG.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants