Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing form-data dependency #9

Open
trevorharwell opened this issue Dec 15, 2021 · 5 comments
Open

Missing form-data dependency #9

trevorharwell opened this issue Dec 15, 2021 · 5 comments
Labels
bug Something isn't working

Comments

@trevorharwell
Copy link

Your client source (https://github.com/ngrok/ngrok-api-typescript/blob/main/src/client.ts#L4) depends on form-data and yet there doesn't seem to be any explicit dependency on it (https://github.com/ngrok/ngrok-api-typescript/blob/main/package.json#L20-L23)

I got an error immediately upon trying to use this library saying that form-data did not exist.

Am I crazy that this library is currently broken? I did see form-data in package-lock so maybe its a difference of npm versions (I am on npm 7.24.2)

@trevorharwell trevorharwell changed the title Missing form-data Dependency Missing form-data dependency Dec 15, 2021
@russorat
Copy link
Contributor

Hi @trevorharwell, thanks for opening this. I am looking into this today.

@russorat russorat added the bug Something isn't working label Dec 16, 2021
@russorat
Copy link
Contributor

I've run through and identified a few issues with this client library, including the ones you've mentioned. I'm working with the team to see how we can address them in the code that generates this client.

@thomas-ngrok
Copy link

@russorat just upvoting as I ran into this today.

@ruscon
Copy link

ruscon commented Feb 12, 2024

bug still exists

@nijikokun
Copy link

@ruscon correct, looks like we need to do a new release. re-opening and pinging the team.

@nijikokun nijikokun reopened this Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants