From b2487751a183f47c67fb30694a80453702a20e96 Mon Sep 17 00:00:00 2001 From: Hugi Thordarson Date: Sun, 25 Feb 2024 09:48:51 +0000 Subject: [PATCH] Add a less confusing non-existent response for public resources --- .../src/main/java/ng/appserver/NGApplication.java | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/ng-appserver/src/main/java/ng/appserver/NGApplication.java b/ng-appserver/src/main/java/ng/appserver/NGApplication.java index 9b9e6495..67f6aae1 100644 --- a/ng-appserver/src/main/java/ng/appserver/NGApplication.java +++ b/ng-appserver/src/main/java/ng/appserver/NGApplication.java @@ -416,6 +416,14 @@ private NGResponse noHandlerResponse( final NGRequest request ) { } final Optional resourceBytes = resourceManager().bytesForPublicResourceNamed( resourcePath ); + + // FIXME: Shouldn't we allow the user to customize the response for a non-existent resource? // Hugi 2024-02-05 + if( resourceBytes.isEmpty() ) { + final NGResponse errorResponse = new NGResponse( "public resource '" + resourcePath + "' does not exist", 404 ); + errorResponse.setHeader( "content-type", "text/html" ); + return errorResponse; + } + return NGResourceRequestHandler.responseForResource( resourceBytes, resourcePath ); }