Deleted unused NGRequest constructor

Author: hugithordarson

ng-adaptor-jetty-servlet/src/main/java/ng/adaptor/jetty/NGServletAdaptor.java

@@ -133,13 +133,7 @@ private static NGRequest servletRequestToNGRequest( final HttpServletRequest sr
 			throw new UncheckedIOException( "Failed to consume the HTTP request's inputstream", e );
 		}
 
-		final NGRequest request = new NGRequest( sr.getMethod(), sr.getRequestURI(), sr.getProtocol(), headerMap( sr ), bos.toByteArray() );
-
-		// FIXME: Form value parsing should really happen within the request object, not in the adaptor // Hugi 2021-12-31
-		request._setFormValues( formValuesFromServletRequest );
-
-		// FIXME: Cookie parsing should happen within the request object, not in the adaptor // Hugi 2021-12-31
-		request._setCookieValues( cookieValues( sr.getCookies() ) );
+		final NGRequest request = new NGRequest( sr.getMethod(), sr.getRequestURI(), sr.getProtocol(), headerMap( sr ), formValuesFromServletRequest, cookieValues( sr.getCookies() ), bos.toByteArray() );
 
 		return request;
 	}

ng-appserver/src/main/java/ng/appserver/NGRequest.java

@@ -71,14 +71,6 @@ public NGRequest( final String method, final String uri, final String httpVersio
 		setContentBytes( contentBytes );
 	}
 
-	/**
-	 * FIXME: Old constructor that doesn't set formValues and cookieValues. It's role is a little unclear at the moment, since I'm still considering if having parsing of form values/cookie values in NGRequest makes sense // Hugi 2025-06-09
-	 */
-	@Deprecated
-	public NGRequest( final String method, final String uri, final String httpVersion, final Map<String, List<String>> headers, final byte[] contentBytes ) {
-		this( method, uri, httpVersion, headers, null, null, contentBytes );
-	}
-
 	/**
 	 * @return The requests form values (query parameters)
 	 */

ng-appserver/src/main/java/ng/xperimental/NGAdaptorRaw.java

@@ -205,7 +205,8 @@ private static NGRequest requestFromInputStream( final InputStream stream ) {
 				content = new byte[0];
 			}
 
-			return new NGRequest( method, uri, httpVersion, headers, content );
+			// FIXME: We're not parsing/passing in formValues or cookies // Hugi 2026-05-11
+			return new NGRequest( method, uri, httpVersion, headers, null, null, content );
 		}
 		catch( final IOException e ) {
 			throw new RuntimeException( e );