Are fractions meant to be exact or a max number of decimal places? #308
theryansmee
started this conversation in
General
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Currently if you pass
option.fraction
to our functions that supports it, it will return a integer or float with a maximum number of decimal places equal to the factionE.G
I'm not sure if this is the desired behaviour. If it is, we currently have tests throughout that fail intermittently because they expect that when a fraction is passed, the returned value should always be an integer.
(I have labelled this as a bug because either the tests are wrong or the fraction logic is wrong)
Beta Was this translation helpful? Give feedback.
All reactions