You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
timeout=createPositiveDurationFlag(kingpin.Flag("nginx.timeout", "A timeout for scraping metrics from NGINX or NGINX Plus.").Default("5s").Envar("TIMEOUT").HintOptions("5s", "10s", "30s", "1m", "5m"))
it probably makes sense to use the same value.
The text was updated successfully, but these errors were encountered:
https://github.com/nginxinc/nginx-plus-go-client/releases/tag/v2.0.0 now supports passing a context to the API calls, so we need to pass a context to
c.nginxClient.GetStats()
nginx-prometheus-exporter/collector/nginx_plus.go
Lines 621 to 625 in 262228e
Figure out if we want to pass a context or a timeout. We already have a timeout that users can set for scraping metrics
nginx-prometheus-exporter/exporter.go
Line 95 in 262228e
it probably makes sense to use the same value.
The text was updated successfully, but these errors were encountered: