-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow using the latest version with older versions of NGINX Plus #629
Comments
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
My assumption is we won't be able to fix this with the given solution for nginxinc/nginx-plus-go-client#222 as it needs an already connected client. |
@alitoufighi yes we need a connection to get the API versions from NGINX. One of the options that I was thinking about was to check the version every time we collect the metrics, but that might be a little bit expensive. I'm open to suggestions 🙂 |
Hmm maybe beginning the connection in a minimal way (is finding the lowest compatible api version any easier? i.e. Also I don't think the call to get API versions is over a specific API version, so it could be doable to communicate over to find the max compatible API version during initialization as well (in the nginx client repo, could be a breaking change?). It might not be the cleanest way either. (might actually give this a shot) |
Blocked until nginx-plus-go-client 1.3.0 is released. When it is, @alitoufighi would you be open to creating a PR for this? |
I want to be able to use the exporter with older versions of NGINX Plus and not have the latest version of the API hardcoded.
Depends on nginxinc/nginx-plus-go-client#222
The text was updated successfully, but these errors were encountered: