Skip to content

Commit 89b173c

Browse files
angular-robotdylhunn
angular-robot
authored and
dylhunn
committed
build: update dependency eslint-plugin-jsdoc to v45 (#50523)
See associated pull request for more information. PR Close #50523
1 parent 2b70a9e commit 89b173c

File tree

5 files changed

+609
-234
lines changed

5 files changed

+609
-234
lines changed

‎aio/.eslintrc.json

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,6 @@
143143
"import/no-deprecated": "warn",
144144
"indent": "off",
145145
"jsdoc/check-alignment": "error",
146-
"jsdoc/newline-after-description": "error",
147146
"jsdoc/no-types": "error",
148147
"max-classes-per-file": "off",
149148
"max-len": [
@@ -231,11 +230,11 @@
231230
"plugin:@angular-eslint/template/recommended"
232231
],
233232
"rules": {
234-
"@angular-eslint/template/accessibility-alt-text": "error",
235-
"@angular-eslint/template/accessibility-elements-content": "error",
236-
"@angular-eslint/template/accessibility-label-has-associated-control": "error",
237-
"@angular-eslint/template/accessibility-table-scope": "error",
238-
"@angular-eslint/template/accessibility-valid-aria": "error",
233+
"@angular-eslint/template/alt-text": "error",
234+
"@angular-eslint/template/elements-content": "error",
235+
"@angular-eslint/template/label-has-associated-control": "error",
236+
"@angular-eslint/template/table-scope": "error",
237+
"@angular-eslint/template/valid-aria": "error",
239238
"@angular-eslint/template/click-events-have-key-events": "error",
240239
"@angular-eslint/template/eqeqeq": "off",
241240
"@angular-eslint/template/mouse-events-have-key-events": "error",

‎aio/content/examples/.eslintrc.json

Lines changed: 142 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,16 @@
11
{
22
"root": true,
3-
"ignorePatterns": [
4-
"*.js",
5-
"styleguide/**/*.avoid.ts"
6-
],
3+
"ignorePatterns": ["*.js", "styleguide/**/*.avoid.ts"],
74
"overrides": [
85
{
9-
"files": [
10-
"*.html"
11-
],
12-
"extends": [
13-
"plugin:@angular-eslint/template/recommended"
14-
],
6+
"files": ["*.html"],
7+
"extends": ["plugin:@angular-eslint/template/recommended"],
158
"rules": {
16-
"@angular-eslint/template/accessibility-alt-text": "error",
17-
"@angular-eslint/template/accessibility-elements-content": "error",
18-
"@angular-eslint/template/accessibility-label-has-associated-control": "error",
19-
"@angular-eslint/template/accessibility-table-scope": "error",
20-
"@angular-eslint/template/accessibility-valid-aria": "error",
9+
"@angular-eslint/template/alt-text": "error",
10+
"@angular-eslint/template/elements-content": "error",
11+
"@angular-eslint/template/label-has-associated-control": "error",
12+
"@angular-eslint/template/table-scope": "error",
13+
"@angular-eslint/template/valid-aria": "error",
2114
"@angular-eslint/template/click-events-have-key-events": "error",
2215
"@angular-eslint/template/eqeqeq": "off",
2316
"@angular-eslint/template/mouse-events-have-key-events": "error",
@@ -27,19 +20,135 @@
2720
}
2821
},
2922
{
30-
"files": [
31-
"*.ts"
32-
],
23+
"files": ["*.ts"],
3324
"extends": [
34-
"plugin:@angular-eslint/ng-cli-compat",
35-
"plugin:@angular-eslint/ng-cli-compat--formatting-add-on",
3625
"plugin:@angular-eslint/template/process-inline-templates"
3726
],
3827
"parserOptions": {
3928
"createDefaultProgram": false,
4029
"project": "content/examples/tsconfig.eslint.json"
4130
},
31+
"plugins": [
32+
"@typescript-eslint",
33+
"@angular-eslint", "eslint-plugin-import", "eslint-plugin-jsdoc", "eslint-plugin-prefer-arrow"],
4234
"rules": {
35+
"@typescript-eslint/interface-name-prefix": "off",
36+
"@typescript-eslint/explicit-member-accessibility": "off",
37+
"sort-keys": "off",
38+
"@angular-eslint/component-class-suffix": "error",
39+
40+
"@angular-eslint/contextual-lifecycle": "error",
41+
"@angular-eslint/directive-class-suffix": "error",
42+
43+
"@angular-eslint/no-conflicting-lifecycle": "error",
44+
"@angular-eslint/no-host-metadata-property": "error",
45+
"@angular-eslint/no-input-rename": "error",
46+
"@angular-eslint/no-inputs-metadata-property": "error",
47+
"@angular-eslint/no-output-native": "error",
48+
"@angular-eslint/no-output-on-prefix": "error",
49+
"@angular-eslint/no-output-rename": "error",
50+
"@angular-eslint/no-outputs-metadata-property": "error",
51+
"@angular-eslint/use-lifecycle-interface": "error",
52+
"@angular-eslint/use-pipe-transform-interface": "error",
53+
"@typescript-eslint/adjacent-overload-signatures": "error",
54+
"@typescript-eslint/array-type": "off",
55+
56+
"@typescript-eslint/consistent-type-assertions": "error",
57+
"@typescript-eslint/no-empty-function": "off",
58+
"@typescript-eslint/no-empty-interface": "error",
59+
"@typescript-eslint/no-explicit-any": "off",
60+
"@typescript-eslint/no-inferrable-types": [
61+
"error",
62+
{
63+
"ignoreParameters": true
64+
}
65+
],
66+
"@typescript-eslint/no-misused-new": "error",
67+
"@typescript-eslint/no-namespace": "error",
68+
"@typescript-eslint/no-parameter-properties": "off",
69+
"@typescript-eslint/no-use-before-define": "off",
70+
"@typescript-eslint/no-var-requires": "off",
71+
"@typescript-eslint/prefer-for-of": "error",
72+
"@typescript-eslint/prefer-function-type": "error",
73+
"@typescript-eslint/prefer-namespace-keyword": "error",
74+
"@typescript-eslint/triple-slash-reference": [
75+
"error",
76+
{
77+
"path": "always",
78+
"types": "prefer-import",
79+
"lib": "always"
80+
}
81+
],
82+
"@typescript-eslint/unified-signatures": "error",
83+
"complexity": "off",
84+
"constructor-super": "error",
85+
"eqeqeq": ["error", "smart"],
86+
"guard-for-in": "error",
87+
"id-blacklist": [
88+
"error",
89+
"any",
90+
"Number",
91+
"number",
92+
"String",
93+
"string",
94+
"Boolean",
95+
"boolean",
96+
"Undefined",
97+
"undefined"
98+
],
99+
"id-match": "error",
100+
"import/no-deprecated": "warn",
101+
"jsdoc/no-types": "error",
102+
"max-classes-per-file": "off",
103+
"no-bitwise": "error",
104+
"no-caller": "error",
105+
"no-cond-assign": "error",
106+
107+
"no-debugger": "error",
108+
"no-empty": "off",
109+
"no-eval": "error",
110+
"no-fallthrough": "error",
111+
"no-invalid-this": "off",
112+
"no-new-wrappers": "error",
113+
"no-restricted-imports": [
114+
"error",
115+
{
116+
"name": "rxjs/Rx",
117+
"message": "Please import directly from 'rxjs' instead"
118+
}
119+
],
120+
"no-throw-literal": "error",
121+
"no-undef-init": "error",
122+
"no-unsafe-finally": "error",
123+
"no-unused-labels": "error",
124+
"no-var": "error",
125+
"object-shorthand": "error",
126+
"one-var": ["error", "never"],
127+
"prefer-const": "error",
128+
"radix": "error",
129+
"use-isnan": "error",
130+
"valid-typeof": "off",
131+
"arrow-body-style": "error",
132+
"arrow-parens": "off",
133+
"comma-dangle": "off",
134+
"curly": "error",
135+
"eol-last": "error",
136+
"jsdoc/check-alignment": "error",
137+
"new-parens": "error",
138+
"no-multiple-empty-lines": "off",
139+
"no-trailing-spaces": "error",
140+
"quote-props": ["error", "as-needed"],
141+
"space-before-function-paren": [
142+
"error",
143+
{
144+
"anonymous": "never",
145+
"asyncArrow": "always",
146+
"named": "never"
147+
}
148+
],
149+
"@typescript-eslint/semi": ["error", "always"],
150+
"@typescript-eslint/type-annotation-spacing": "error",
151+
43152
"@typescript-eslint/ban-types": "error",
44153
"@angular-eslint/component-selector": [
45154
"error",
@@ -61,12 +170,15 @@
61170
"@typescript-eslint/dot-notation": ["error", {"allowIndexSignaturePropertyAccess": true}],
62171
"indent": "off",
63172
"max-len": ["error", {"code": 120, "ignoreUrls": true}],
64-
"@typescript-eslint/member-delimiter-style": ["error", {
65-
"singleline": {
66-
"delimiter": "comma",
67-
"requireLast": false
173+
"@typescript-eslint/member-delimiter-style": [
174+
"error",
175+
{
176+
"singleline": {
177+
"delimiter": "comma",
178+
"requireLast": false
179+
}
68180
}
69-
}],
181+
],
70182
"@typescript-eslint/member-ordering": "off",
71183
"@typescript-eslint/naming-convention": "off",
72184
"no-console": ["error", {"allow": ["log", "warn", "error"]}],
@@ -88,7 +200,11 @@
88200
"no-use-before-define": "off",
89201
"prefer-arrow/prefer-arrow-functions": "off",
90202
"quotes": "off",
91-
"@typescript-eslint/quotes": ["error", "single", {"avoidEscape": true, "allowTemplateLiterals": true }],
203+
"@typescript-eslint/quotes": [
204+
"error",
205+
"single",
206+
{"avoidEscape": true, "allowTemplateLiterals": true}
207+
],
92208
"semi": "error"
93209
}
94210
}

‎aio/content/examples/template-syntax/src/app/app.component.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ <h3>
180180

181181
<a class="to-toc" href="#toc">top</a>
182182

183-
<!-- eslint-disable @angular-eslint/template/accessibility-alt-text -->
183+
<!-- eslint-disable @angular-eslint/template/alt-text -->
184184
<!-- property vs. attribute -->
185185
<hr><h2 id="prop-vs-attrib">Property vs. Attribute (img examples)</h2>
186186
<!-- examine the following <img> tag in the browser tools -->
@@ -191,7 +191,7 @@ <h3>
191191

192192
<img [src]="iconUrl"/>
193193
<img [attr.src]="villainImageUrl"/>
194-
<!-- eslint-enable @angular-eslint/template/accessibility-alt-text -->
194+
<!-- eslint-enable @angular-eslint/template/alt-text -->
195195
<a class="to-toc" href="#toc">top</a>
196196

197197
<!-- buttons -->

‎aio/package.json

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -81,10 +81,10 @@
8181
"devDependencies": {
8282
"@angular-devkit/architect-cli": "0.1600.0",
8383
"@angular-devkit/build-angular": "16.0.0",
84-
"@angular-eslint/builder": "^15.0.0",
85-
"@angular-eslint/eslint-plugin": "^15.0.0",
86-
"@angular-eslint/eslint-plugin-template": "^15.0.0",
87-
"@angular-eslint/template-parser": "^15.0.0",
84+
"@angular-eslint/builder": "16.0.3",
85+
"@angular-eslint/eslint-plugin": "16.0.3",
86+
"@angular-eslint/eslint-plugin-template": "16.0.3",
87+
"@angular-eslint/template-parser": "^16.0.3",
8888
"@angular/build-tooling": "https://github.com/angular/dev-infra-private-build-tooling-builds.git#7dad055464ea9847e4870b9e3baad1f0c417bdf7",
8989
"@angular/cli": "16.0.0",
9090
"@angular/compiler-cli": "16.0.0",
@@ -98,8 +98,8 @@
9898
"@types/lunr": "^2.3.3",
9999
"@types/node": "^12.7.9",
100100
"@types/trusted-types": "^2.0.2",
101-
"@typescript-eslint/eslint-plugin": "5.59.2",
102-
"@typescript-eslint/parser": "5.59.2",
101+
"@typescript-eslint/eslint-plugin": "5.59.8",
102+
"@typescript-eslint/parser": "5.59.8",
103103
"archiver": "^5.3.0",
104104
"assert": "^2.0.0",
105105
"canonical-path": "1.0.0",
@@ -110,11 +110,11 @@
110110
"dgeni": "^0.4.14",
111111
"dgeni-packages": "^0.30.0",
112112
"entities": "^4.0.0",
113-
"eslint": "^8.0.0",
114-
"eslint-plugin-import": "^2.23.4",
115-
"eslint-plugin-jasmine": "^4.1.2",
116-
"eslint-plugin-jsdoc": "^41.0.0",
117-
"eslint-plugin-prefer-arrow": "^1.2.3",
113+
"eslint": "8.41.0",
114+
"eslint-plugin-import": "2.27.5",
115+
"eslint-plugin-jasmine": "4.1.3",
116+
"eslint-plugin-jsdoc": "45.0.0",
117+
"eslint-plugin-prefer-arrow": "1.2.3",
118118
"find-free-port": "^2.0.0",
119119
"firebase-tools": "^12.0.0",
120120
"fs-extra": "^11.0.0",
@@ -156,7 +156,7 @@
156156
"tree-kill": "^1.1.0",
157157
"ts-node": "^10.8.1",
158158
"tsec": "^0.2.2",
159-
"tslint": "~6.1.3",
159+
"tslint": "6.1.3",
160160
"typescript": "~5.0.2",
161161
"uglify-js": "^3.13.3",
162162
"unist-util-filter": "^2.0.3",

0 commit comments

Comments
 (0)