Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to use new exec-alternative API #2

Open
nfischer opened this issue Oct 9, 2016 · 3 comments
Open

Update to use new exec-alternative API #2

nfischer opened this issue Oct 9, 2016 · 3 comments
Assignees
@nfischer
Labels
enhancement

Comments

@nfischer
Copy link
Owner

nfischer commented Oct 9, 2016

To eliminate all security holes and get a consistent cross-platform API, this should migrate to ShellJS's exec-replacement after the next release (implementation can start once it has been merged).
@nfischer nfischer mentioned this issue Oct 9, 2016
Closed
@nfischer nfischer self-assigned this Nov 1, 2016
@nfischer
Copy link
Owner Author

nfischer commented Nov 1, 2016

Blocked by shelljs/shelljs#524

@jhenry9636
Copy link

@nfischer Sounds like you been working hard. Just wanted to check in to see where you are with this. Can't thank you enough for the fix.

@nfischer
Copy link
Owner Author

@jhenry9636 thanks for pinging the thread. I'm still hacking out a prototype, but will ping the linked PR once I have something working a bit better.

In terms of this project, switching to the new API (once available) should be pretty easy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nfischer nfischer

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jhenry9636 @nfischer