Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update all modules #187

Merged
merged 28 commits into from
Mar 3, 2025
Merged

Update all modules #187

merged 28 commits into from
Mar 3, 2025

Conversation

LouisLeNezet
Copy link
Collaborator

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/phaseimpute branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@LouisLeNezet LouisLeNezet self-assigned this Feb 26, 2025
@LouisLeNezet LouisLeNezet added the enhancement New feature or request label Feb 26, 2025
@LouisLeNezet LouisLeNezet added this to the v1.1.0 milestone Feb 26, 2025
jasmezz
jasmezz approved these changes Mar 3, 2025
View reviewed changes
Copy link

@jasmezz jasmezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LouisLeNezet LouisLeNezet merged commit 4fe140f into nf-core:dev Mar 3, 2025
12 checks passed
@LouisLeNezet
Copy link
Collaborator Author

Thanks for your reviews @jasmezz !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasmezz jasmezz jasmezz approved these changes

@atrigila atrigila Awaiting requested review from atrigila

Assignees

@LouisLeNezet LouisLeNezet

Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@LouisLeNezet @jasmezz