Update Output Docs for Collapsed Abundance Tables #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there, looks good to me, why did you close the PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR is a minor output documentation update.
Recently I was confused why the qiime output relative abundance tsvs only went to level 6, not level 7 when the reference database we are using includes level 7. In the parameter schema, it shows that the level is controlled by
--tax_agglom_maxwhich defaults to 6, so hopefully the output docs better reflect the situation with this change.I agree that level 6 is a sensible default, I am not proposing to change that, just the output docs! :)
To verify the changed documentation, I believe this is the code that collapses the taxa for absolute abundance counts, and relative abundance counts.