Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong websocket path #193

Open
rawtaz opened this issue Sep 26, 2024 · 3 comments
Open

Wrong websocket path #193

rawtaz opened this issue Sep 26, 2024 · 3 comments
Labels
bug Something isn't working needs info setup

Comments

@rawtaz
Copy link

rawtaz commented Sep 26, 2024

The websocket path is /socket.io in the source code but /whiteboard in the documentation.

The result of this is that the client fails to connect to the service, when configured according to the documentation/example.

I suggest changing the code so that it is using /whiteboard, as that makes more sense than /socket.io (in particular since there may be other services using websockets on the host in question, and it's therefore better to name the endpoints for what they are instead of by technology).

I also mentioned this earlier here ten days ago, perhaps that information is useful to those having problems getting it running.

@rawtaz rawtaz added 0. Needs triage bug Something isn't working labels Sep 26, 2024
@juliusknorr
Copy link
Member

The documentation describes a scenario where the server is proxied behind the /whiteboard prefix which should work fine as the socket URL then becomes /whiteboard/socket.io. We have this working fine in multiple installations, so I'd be curious if you maybe missed adding the /whiteboard path to the configured server URL, e.g. https://cloud.example.com/whiteboard in the admin settings.

@KunaPrime
Copy link

i'm facing exact same issue, running nginx proxy, and i was able to solve it with this, but i assume this is not desirable solution at all

@brakhane
Copy link

i'm facing exact same issue, running nginx proxy, and i was able to solve it with this, but i assume this is not desirable solution at all

If you add a trailing slash to proxy_pass, eg. change proxy_pass http://localhost:3002; to proxy_pass http://localhost:3002/;, it should work even when using /whiteboard/ as a location.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs info setup
Projects
None yet
Development

No branches or pull requests

4 participants