Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape should not close the modal #104

Closed
juliusknorr opened this issue Aug 6, 2024 · 1 comment
Closed

Escape should not close the modal #104

juliusknorr opened this issue Aug 6, 2024 · 1 comment
Assignees
@grnd-alt
Labels
bug Something isn't working
Milestone
1.0

Comments

@juliusknorr
Copy link
Member

Steps to reproduce:

  • Select an element or type something
  • Press escape to cancel the current operation

We should not close the modal so need to overrule the keydown handler from the viewer app
@juliusknorr juliusknorr added the bug Something isn't working label Aug 6, 2024
@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Office team Aug 19, 2024
@juliusknorr juliusknorr added this to the 1.0 milestone Aug 29, 2024
@juliusknorr
Copy link
Member Author

Fixed by #130

@github-project-automation github-project-automation bot moved this from 👀 In review to ☑️ Done in 📝 Office team Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grnd-alt grnd-alt

Labels
bug Something isn't working
Projects
📝 Office team
Archived in project
Milestone
1.0
Development

No branches or pull requests
2 participants
@juliusknorr @grnd-alt